Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 10031036: Revert 131177 - aura: Change shared context to be offscreen for arm (Closed)

Created:
8 years, 8 months ago by mazda
Modified:
8 years, 8 months ago
Reviewers:
piman
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org, apatrick_chromium
Visibility:
Public.

Description

Revert 131177 - aura: Change shared context to be offscreen for arm This change causes Chrome OS to get stuck in the login screen on Lumpy and Stumpy, so it is reverted for now. BUG=chrome-os-partner:8831 TEST=Manually checked that I can log in successfully ARM drivers don't like to have 2 EGLSurface on the same Window. So we need to make the UI shared context offscren. This also requires the image transport surface to be an "offscreen" GLSurface (a pbuffer), however the GLES2Decoder needs to be "onscreen" (i.e. it calls SwapBuffers on the surface instead managing the offscreen buffers itself). So this decouples the 2 notions of "offscreen". BUG=chrome-os-partner:8284 TEST=gpu_unittests. Aura chrome --ui-use-gpu-process with poster circle and webgl on tegra, lumpy, desktop GL. Desktop chrome with poster circle and webgl. Review URL: http://codereview.chromium.org/10007034 TBR=piman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=131559

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -37 lines) Patch
M content/browser/renderer_host/image_transport_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/gpu/texture_image_transport_surface.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.h View 2 chunks +0 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 4 chunks +24 lines, -24 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_mock.h View 1 chunk +1 line, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/demos/framework/window.cc View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/gles2_conform_support/egl/display.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
mazda
8 years, 8 months ago (2012-04-10 16:52:11 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698