Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: src/hydrogen-instructions.cc

Issue 10031031: Remove write-barriers for stores to new-space objects. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments by Erik Corry. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/hydrogen-instructions.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 444 matching lines...) Expand 10 before | Expand all | Expand 10 after
455 if (changes_flags == AllSideEffectsFlagSet()) { 455 if (changes_flags == AllSideEffectsFlagSet()) {
456 stream->Add("*"); 456 stream->Add("*");
457 } else { 457 } else {
458 bool add_comma = false; 458 bool add_comma = false;
459 #define PRINT_DO(type) \ 459 #define PRINT_DO(type) \
460 if (changes_flags.Contains(kChanges##type)) { \ 460 if (changes_flags.Contains(kChanges##type)) { \
461 if (add_comma) stream->Add(","); \ 461 if (add_comma) stream->Add(","); \
462 add_comma = true; \ 462 add_comma = true; \
463 stream->Add(#type); \ 463 stream->Add(#type); \
464 } 464 }
465 GVN_FLAG_LIST(PRINT_DO); 465 GVN_TRACKED_FLAG_LIST(PRINT_DO);
466 GVN_UNTRACKED_FLAG_LIST(PRINT_DO);
466 #undef PRINT_DO 467 #undef PRINT_DO
467 } 468 }
468 stream->Add("]"); 469 stream->Add("]");
469 } 470 }
470 471
471 472
472 void HValue::PrintNameTo(StringStream* stream) { 473 void HValue::PrintNameTo(StringStream* stream) {
473 stream->Add("%s%d", representation_.Mnemonic(), id()); 474 stream->Add("%s%d", representation_.Mnemonic(), id());
474 } 475 }
475 476
(...skipping 1250 matching lines...) Expand 10 before | Expand all | Expand 10 after
1726 } 1727 }
1727 1728
1728 1729
1729 void HStoreNamedField::PrintDataTo(StringStream* stream) { 1730 void HStoreNamedField::PrintDataTo(StringStream* stream) {
1730 object()->PrintNameTo(stream); 1731 object()->PrintNameTo(stream);
1731 stream->Add("."); 1732 stream->Add(".");
1732 stream->Add(*String::cast(*name())->ToCString()); 1733 stream->Add(*String::cast(*name())->ToCString());
1733 stream->Add(" = "); 1734 stream->Add(" = ");
1734 value()->PrintNameTo(stream); 1735 value()->PrintNameTo(stream);
1735 stream->Add(" @%d%s", offset(), is_in_object() ? "[in-object]" : ""); 1736 stream->Add(" @%d%s", offset(), is_in_object() ? "[in-object]" : "");
1737 if (NeedsWriteBarrier()) {
1738 stream->Add(" (write-barrier)");
1739 }
1736 if (!transition().is_null()) { 1740 if (!transition().is_null()) {
1737 stream->Add(" (transition map %p)", *transition()); 1741 stream->Add(" (transition map %p)", *transition());
1738 } 1742 }
1739 } 1743 }
1740 1744
1741 1745
1742 void HStoreKeyedFastElement::PrintDataTo(StringStream* stream) { 1746 void HStoreKeyedFastElement::PrintDataTo(StringStream* stream) {
1743 object()->PrintNameTo(stream); 1747 object()->PrintNameTo(stream);
1744 stream->Add("["); 1748 stream->Add("[");
1745 key()->PrintNameTo(stream); 1749 key()->PrintNameTo(stream);
(...skipping 588 matching lines...) Expand 10 before | Expand all | Expand 10 after
2334 2338
2335 2339
2336 void HCheckPrototypeMaps::Verify() { 2340 void HCheckPrototypeMaps::Verify() {
2337 HInstruction::Verify(); 2341 HInstruction::Verify();
2338 ASSERT(HasNoUses()); 2342 ASSERT(HasNoUses());
2339 } 2343 }
2340 2344
2341 #endif 2345 #endif
2342 2346
2343 } } // namespace v8::internal 2347 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/hydrogen-instructions.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698