Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Side by Side Diff: chrome/browser/history/history_notifications.h

Issue 10031028: Single URL Expires Were Not Being Deleted. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/history/history_extension_api.cc ('k') | chrome/browser/history/history_types.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Structs that hold data used in broadcasting notifications. 5 // Structs that hold data used in broadcasting notifications.
6 6
7 #ifndef CHROME_BROWSER_HISTORY_HISTORY_NOTIFICATIONS_H__ 7 #ifndef CHROME_BROWSER_HISTORY_HISTORY_NOTIFICATIONS_H__
8 #define CHROME_BROWSER_HISTORY_HISTORY_NOTIFICATIONS_H__ 8 #define CHROME_BROWSER_HISTORY_HISTORY_NOTIFICATIONS_H__
9 #pragma once 9 #pragma once
10 10
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 }; 50 };
51 51
52 // Details for NOTIFICATION_HISTORY_URLS_DELETED. 52 // Details for NOTIFICATION_HISTORY_URLS_DELETED.
53 struct URLsDeletedDetails : public HistoryDetails { 53 struct URLsDeletedDetails : public HistoryDetails {
54 URLsDeletedDetails(); 54 URLsDeletedDetails();
55 virtual ~URLsDeletedDetails(); 55 virtual ~URLsDeletedDetails();
56 56
57 // Set when all history was deleted. False means just a subset was deleted. 57 // Set when all history was deleted. False means just a subset was deleted.
58 bool all_history; 58 bool all_history;
59 59
60 // The URLRows which have been deleted. 60 // The URLRows of URLs deleted. This is valid only when all_history is false
61 // indicating that a subset of history has been deleted.
61 URLRows rows; 62 URLRows rows;
62
63 // The list of unique URLs affected. This is valid only when a subset of
64 // history is deleted. When all of it is deleted, this will be empty, since
65 // we do not bother to list all URLs. (This information can be gleaned from
66 // |rows| but, since there are several clients who need the set, we pre-build
67 // it so that the clients don't have to.)
68 std::set<GURL> urls;
69 }; 63 };
70 64
71 // Details for NOTIFY_URLS_STARRED. 65 // Details for NOTIFY_URLS_STARRED.
72 struct URLsStarredDetails : public HistoryDetails { 66 struct URLsStarredDetails : public HistoryDetails {
73 explicit URLsStarredDetails(bool being_starred); 67 explicit URLsStarredDetails(bool being_starred);
74 virtual ~URLsStarredDetails(); 68 virtual ~URLsStarredDetails();
75 69
76 // The new starred state of the list of URLs. True when they are being 70 // The new starred state of the list of URLs. True when they are being
77 // starred, false when they are being unstarred. 71 // starred, false when they are being unstarred.
78 bool starred; 72 bool starred;
(...skipping 16 matching lines...) Expand all
95 virtual ~KeywordSearchTermDetails(); 89 virtual ~KeywordSearchTermDetails();
96 90
97 GURL url; 91 GURL url;
98 TemplateURLID keyword_id; 92 TemplateURLID keyword_id;
99 string16 term; 93 string16 term;
100 }; 94 };
101 95
102 } // namespace history 96 } // namespace history
103 97
104 #endif // CHROME_BROWSER_HISTORY_HISTORY_NOTIFICATIONS_H__ 98 #endif // CHROME_BROWSER_HISTORY_HISTORY_NOTIFICATIONS_H__
OLDNEW
« no previous file with comments | « chrome/browser/history/history_extension_api.cc ('k') | chrome/browser/history/history_types.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698