Fix up if statement curly braces issues.

Fix up if statement curly braces issues.

Java styleguide requires curly braces for all if statements except for
single line if statements without else case.

BUG=None
TBR=qinmin@chromium.org

Committed: https://crrev.com/e41d8001e9141bcfe304e497be4a0d40c705175e
Cr-Commit-Position: refs/heads/master@{#321188}

[aurimas (slooooooooow), 2015-03-12 17:28:12]

aurimas@chromium.org changed reviewers:
+ lambroslambrou@chromium.org, mef@chromium.org, nyquist@chromium.org,
qinmin@chromium.org, tedchoc@chromium.org

[aurimas (slooooooooow), 2015-03-12 17:28:12]

nyquist@:
base/android/*
chrome/*
sync/android/*

tedchoc@:
components/bookmarks/*
content/public/android/*
ui/android/*

mef@:
components/cronet/*
net/*

qinmin@:
media/base/android/*

lambroslambrou@:
remoting/*

[aurimas (slooooooooow), 2015-03-12 17:28:43]

On 2015/03/12 at 17:28:12, aurimas wrote:
> nyquist@:
> base/android/*
> chrome/*
> sync/android/*
> 
> tedchoc@:
> components/bookmarks/*
> content/public/android/*
> ui/android/*
> 
> mef@:
> components/cronet/*
> net/*
> 
> qinmin@:
> media/base/android/*
> 
> lambroslambrou@:
> remoting/*

Please take a look at the directories listed above. Thanks!
Aurimas

[Ted C, 2015-03-12 17:50:54]

On 2015/03/12 17:28:43, aurimas wrote:
> On 2015/03/12 at 17:28:12, aurimas wrote:
> > nyquist@:
> > base/android/*
> > chrome/*
> > sync/android/*
> > 
> > tedchoc@:
> > components/bookmarks/*
> > content/public/android/*
> > ui/android/*
> > 
> > mef@:
> > components/cronet/*
> > net/*
> > 
> > qinmin@:
> > media/base/android/*
> > 
> > lambroslambrou@:
> > remoting/*
> 
> Please take a look at the directories listed above. Thanks!
> Aurimas

lgtm for:
components/bookmarks/*
content/public/android/*
ui/android/*

[Lambros, 2015-03-12 19:12:44]

remoting/ lgtm

[nyquist, 2015-03-12 19:16:31]

base/android, chrome, sync/android lgtm

[aurimas (slooooooooow), 2015-03-12 21:36:24]

TBR qinmin@ since he is OOO for a while.

[mef, 2015-03-13 14:39:13]

components/cronet/* lgtm

https://chromiumcodereview.appspot.com/1002883002/diff/1/components/cronet/an...
File components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequest.java
(left):

https://chromiumcodereview.appspot.com/1002883002/diff/1/components/cronet/an...
components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequest.java:690:
return -1;
Just to make sure I understand it correctly:

- Is 'if' statement expected to be one-line if it fits, or is it up to coder?
- Unless it fits on one line are curly braces always required, including simple
one-liners?

[Ted C, 2015-03-13 16:33:21]

https://chromiumcodereview.appspot.com/1002883002/diff/1/components/cronet/an...
File components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequest.java
(left):

https://chromiumcodereview.appspot.com/1002883002/diff/1/components/cronet/an...
components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequest.java:690:
return -1;
On 2015/03/13 14:39:12, mef wrote:
> Just to make sure I understand it correctly:
> 
> - Is 'if' statement expected to be one-line if it fits, or is it up to coder?

Up to the coder and based on readability.

But if you have something like:

if (<short boolean) return;

Then I would push for it being one line despite objections from the coder.

> - Unless it fits on one line are curly braces always required, including
simple
> one-liners? 

Correct, if it doesn't all go on one line, curly braces are always required in
Java.

[aurimas (slooooooooow), 2015-03-18 17:19:38]

The CQ bit was checked by aurimas@chromium.org

[aurimas (slooooooooow), 2015-03-18 17:19:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, lambroslambrou@chromium.org, mef@chromium.org,
nyquist@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1002883002/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2015-03-18 17:19:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1002883002/20001

[commit-bot: I haz the power, 2015-03-18 19:21:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-18 19:22:09]

Patchset 2 (id:??) landed as
https://crrev.com/e41d8001e9141bcfe304e497be4a0d40c705175e
Cr-Commit-Position: refs/heads/master@{#321188}