Update use of TimeDelta in chrome/browser/*, ui/views/*, and other places.

Update use of TimeDelta in chrome/browser/*, ui/views/*, and other places.

R=ben@chromium.org
BUG=108171
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137682

[Ben Goodger (Google), 2012-04-09 19:28:49]

lgtm

[Ted Vessenes, 2012-04-09 23:30:36]

On 2012/04/09 19:28:49, Ben Goodger (Google) wrote:
> lgtm

I'm getting try bot failures on unit tests on linux_chromeos.  When I get the
chance, I'll review this more to see what's causing it.  I might try to isolate
the offending code and commit the rest in a patch now, then get back to you with
the other fix.

[Ted Vessenes, 2012-05-15 01:49:08]

jar@chromium.org: Please review base/process_util_linux.cc.  That block of code
triggered once and I figured that as long as NOTREACHED() was executing, the
code might as well tell me what's wrong.  Feel free to look over the other stuff
if you're interested, of course.

ben@chromium.org: I finally got back to looking into this patch and found two
reasons that the try bots were failing on it.  One was a simple miss on my part
in file_browser_notifications_browsertest.cc.

The other however *seems* to be a unit test (InspectSharedWorker) which was
flaky on OSX and under certain builds on Linux and Windows (specifically when
debug is on).  For whatever reason, this patch seems to make the flaky unit test
always fail on Windows.  When this test is disabled on windows, everything else
seems to pass.

The code for this is in chrome/browser/debugger/devtools_sanity_unittest.cc. 
The CL I've uploaded disables this test.  I'm not sure if this is totally kosher
though, so I'd like some advice here.  If you want this solved another way, let
me know and I'll give it a try.

[Ilya Sherman, 2012-05-15 05:30:01]

https://chromiumcodereview.appspot.com/10026013/diff/22003/base/process_util_...
File base/process_util_linux.cc (right):

https://chromiumcodereview.appspot.com/10026013/diff/22003/base/process_util_...
base/process_util_linux.cc:79: << "'\n";
nit: No need for the trailing "\n" unless you want two -- DLOG automatically
ends an end-of-line character.

[jar (doing other things), 2012-05-15 18:37:51]

Base change LGTM.  I only did a skimming of the changes to use TimeDelta
elsewhere, and the approach seemed fine as well.

[Ted Vessenes, 2012-05-15 18:40:23]

Do you have an opinion on labeling the InspectSharedWorker test flaky on windows
releases?  I'm always wary of deactivating unit tests and I've never done it
before in Chromium, so I definitely want a second opinion here.

[jar (doing other things), 2012-05-15 19:03:24]

Looking at the source for that test... it looks to be heavily marked up as flaky
already (with a bug, etc.)

On 2012/05/15 18:40:23, tedv wrote:
> Do you have an opinion on labeling the InspectSharedWorker test flaky on
windows
> releases?  I'm always wary of deactivating unit tests and I've never done it
> before in Chromium, so I definitely want a second opinion here.

[commit-bot: I haz the power, 2012-05-17 15:51:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/10026013/27031

[commit-bot: I haz the power, 2012-05-17 17:47:41]

Change committed as 137682