Issue 10025038: Debug stub: Remove the GDB_RSP_ABI_* #defines

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10025038: Debug stub: Remove the GDB_RSP_ABI_* #defines (Closed)

Created:
8 years, 8 months ago by Mark Seaborn

Modified:
8 years, 8 months ago

Reviewers:
eaeltsin, bradn

CC:
native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/native_client/trunk/src/native_client

Visibility:
Public.

More Reviews

Description

Debug stub: Remove the GDB_RSP_ABI_* #defines Use the NACL_BUILD_ARCH/NACL_BUILD_SUBARCH #defines that the rest of the NaCl codebase uses instead. Also use if() instead of #if because it allows more code paths to be compiled-tested. BUG=http://code.google.com/p/nativeclient/issues/detail?id=2728 TEST=run_debug_stub_test Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=8315

Patch Set 1 #

Patch Set 2 : Fix dependencies #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -77 lines)			Patch
M	src/trusted/gdb_rsp/abi.cc	View	1	3 chunks	+13 lines, -10 lines	0 comments	Download
M	src/trusted/gdb_rsp/build.scons	View	1	3 chunks	+6 lines, -16 lines	0 comments	Download
M	src/trusted/gdb_rsp/gdb_rsp.gyp	View	1	3 chunks	+11 lines, -51 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages