Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 10025015: Add operator= to InputMethodProperty. (Closed)

Created:
8 years, 8 months ago by Yusuke Sato
Modified:
8 years, 8 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Add operator= to InputMethodProperty. This is for writing unit tests for InputMethodManager, BUG=chromium-os:19655 TEST=ran unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=131325

Patch Set 1 #

Patch Set 2 : added operator!= per offline discussion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -0 lines) Patch
M chrome/browser/chromeos/input_method/input_method_property.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_property.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/input_method/input_method_property_unittest.cc View 1 1 chunk +33 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Yusuke Sato
8 years, 8 months ago (2012-04-09 02:06:11 UTC) #1
yoshiki
8 years, 8 months ago (2012-04-09 02:07:55 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698