Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: src/profile-generator.h

Issue 10025014: Revert "External references should not affect dominance relation." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/api.cc ('k') | src/profile-generator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/profile-generator.h
diff --git a/src/profile-generator.h b/src/profile-generator.h
index c88837f0084d0fe15f8e514781877e03707717e7..1fa647eef1df03e3e6d1ba819cfb32e51d09efb5 100644
--- a/src/profile-generator.h
+++ b/src/profile-generator.h
@@ -477,7 +477,8 @@ class HeapGraphEdge BASE_EMBEDDED {
return name_;
}
HeapEntry* to() { return to_; }
- INLINE(HeapEntry* from());
+
+ HeapEntry* From();
private:
int child_index_ : 29;
@@ -563,8 +564,6 @@ class HeapEntry BASE_EMBEDDED {
void clear_paint() { painted_ = false; }
bool painted() { return painted_; }
void paint() { painted_ = true; }
- bool reachable_from_window() { return reachable_from_window_; }
- void set_reachable_from_window() { reachable_from_window_ = true; }
void SetIndexedReference(HeapGraphEdge::Type type,
int child_index,
@@ -601,9 +600,8 @@ class HeapEntry BASE_EMBEDDED {
const char* TypeAsString();
unsigned painted_: 1;
- unsigned reachable_from_window_: 1;
unsigned type_: 4;
- int children_count_: 26;
+ int children_count_: 27;
int retainers_count_;
int self_size_;
union {
@@ -1102,8 +1100,7 @@ class HeapSnapshotGenerator : public SnapshottingProgressReportingInterface {
bool CalculateRetainedSizes();
bool CountEntriesAndReferences();
bool FillReferences();
- void FillPostorderIndexes(Vector<HeapEntry*>* entries);
- void MarkWindowReachableObjects();
+ void FillReversePostorderIndexes(Vector<HeapEntry*>* entries);
void ProgressStep();
bool ProgressReport(bool force = false);
bool SetEntriesDominators();
« no previous file with comments | « src/api.cc ('k') | src/profile-generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698