chrome/test/data/extensions/api_test/permissions/optional/background.js - Issue 10025007: Convert tabs, windows, and extension APIs to feature system.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/permissions/optional/background.js

Issue 10025007: Convert tabs, windows, and extension APIs to feature system. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: blah Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/api_test/events/background.js ('k') | chrome/test/data/extensions/api_test/stubs/content_script.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/permissions/optional/background.js

diff --git a/chrome/test/data/extensions/api_test/permissions/optional/background.js b/chrome/test/data/extensions/api_test/permissions/optional/background.js

index 689138253b6ad7e011bf79e2e03fc45e07a90795..61617be142fc166b32eb295fb0bcc8e7ba18486c 100644

--- a/chrome/test/data/extensions/api_test/permissions/optional/background.js

+++ b/chrome/test/data/extensions/api_test/permissions/optional/background.js

@@ -13,7 +13,7 @@ var NOT_OPTIONAL_ERROR =

"Optional permissions must be listed in extension manifest.";

var NO_TABS_PERMISSION =

- "You do not have permission to use 'windows.getAll'.";

+ "cannot be used in this context.";

var REQUIRED_ERROR =

"You cannot remove required permissions.";

@@ -135,7 +135,8 @@ chrome.test.getConfig(function(config) {

chrome.test.fail("Should not have tabs API permission.");

});

} catch (e) {

- assertTrue(e.message.indexOf(NO_TABS_PERMISSION) == 0);

+ console.log(e.message);

+ assertTrue(e.message.indexOf(NO_TABS_PERMISSION) > -1);

}

listenOnce(chrome.permissions.onAdded,

function(permissions) {

@@ -209,7 +210,7 @@ chrome.test.getConfig(function(config) {

chrome.test.fail("Should not have tabs API permission.");

});

} catch (e) {

- assertTrue(e.message.indexOf(NO_TABS_PERMISSION) == 0);

+ assertTrue(e.message.indexOf(NO_TABS_PERMISSION) > -1);

}

}));

@@ -309,7 +310,7 @@ chrome.test.getConfig(function(config) {

chrome.test.fail("Should not have tabs API permission.");

});

} catch (e) {

- assertTrue(e.message.indexOf(NO_TABS_PERMISSION) == 0);

+ assertTrue(e.message.indexOf(NO_TABS_PERMISSION) > -1);

}

});