Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Unified Diff: vm/pages.cc

Issue 10025003: Revert change 6302 until the compiler warning is addressed. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/pages.h ('k') | vm/raw_object.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/pages.cc
===================================================================
--- vm/pages.cc (revision 6302)
+++ vm/pages.cc (working copy)
@@ -49,21 +49,6 @@
}
-RawObject* HeapPage::FindObject(FindObjectVisitor* visitor) const {
- uword obj_addr = first_object_start();
- uword end_addr = top();
- while (obj_addr < end_addr) {
- RawObject* raw_obj = RawObject::FromAddr(obj_addr);
- if (raw_obj->FindObject(visitor)) {
- return raw_obj; // Found object, return it.
- }
- obj_addr += raw_obj->Size();
- }
- ASSERT(obj_addr == end_addr);
- return Object::null();
-}
-
-
PageSpace::PageSpace(Heap* heap, intptr_t max_capacity, bool is_executable)
: freelist_(),
heap_(heap),
@@ -221,29 +206,6 @@
}
-RawObject* PageSpace::FindObject(FindObjectVisitor* visitor) const {
- ASSERT(Isolate::Current()->no_gc_scope_depth() != 0);
- HeapPage* page = pages_;
- while (page != NULL) {
- RawObject* obj = page->FindObject(visitor);
- if (obj != Object::null()) {
- return obj;
- }
- page = page->next();
- }
-
- page = large_pages_;
- while (page != NULL) {
- RawObject* obj = page->FindObject(visitor);
- if (obj != Object::null()) {
- return obj;
- }
- page = page->next();
- }
- return Object::null();
-}
-
-
void PageSpace::MarkSweep(bool invoke_api_callbacks) {
// MarkSweep is not reentrant. Make sure that is the case.
ASSERT(!sweeping_);
« no previous file with comments | « vm/pages.h ('k') | vm/raw_object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698