Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1098)

Unified Diff: media/base/video_frame.h

Issue 10024072: Cull unnecessary media::VideoFrame::Formats from the enum. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/base/video_frame.cc » ('j') | media/base/video_frame.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/video_frame.h
diff --git a/media/base/video_frame.h b/media/base/video_frame.h
index 13460096869c9dffe68cb77fd0b24e040a2e25e0..c4b1c09c1db0eb91da2aeb7c35f39c0adc151850 100644
--- a/media/base/video_frame.h
+++ b/media/base/video_frame.h
@@ -27,20 +27,22 @@ class MEDIA_EXPORT VideoFrame : public base::RefCountedThreadSafe<VideoFrame> {
// http://www.fourcc.org/rgb.php
// http://www.fourcc.org/yuv.php
// Keep in sync with WebKit::WebVideoFrame!
+ // (keeping in sync means deleting values is a multi-stage process; please
+ // ignore the UNUSED_TO_BE_DELETED<N> values).
enum Format {
- INVALID, // Invalid format value. Used for error reporting.
- RGB555, // 16bpp RGB packed 5:5:5
- RGB565, // 16bpp RGB packed 5:6:5
- RGB24, // 24bpp RGB packed 8:8:8
- RGB32, // 32bpp RGB packed with extra byte 8:8:8
- RGBA, // 32bpp RGBA packed 8:8:8:8
- YV12, // 12bpp YVU planar 1x1 Y, 2x2 VU samples
- YV16, // 16bpp YVU planar 1x1 Y, 2x1 VU samples
- NV12, // 12bpp YVU planar 1x1 Y, 2x2 UV interleaving samples
- EMPTY, // An empty frame.
- ASCII, // A frame with ASCII content. For testing only.
- I420, // 12bpp YVU planar 1x1 Y, 2x2 UV samples.
- NATIVE_TEXTURE, // Native texture. Pixel-format agnostic.
+ INVALID = 0, // Invalid format value. Used for error reporting.
scherkus (not reviewing) 2012/04/10 21:32:31 OCD nit: should these // be aligned or something b
Ami GONE FROM CHROMIUM 2012/04/10 22:01:07 Done.
+ UNUSED_TO_BE_DELETED1 = 1,
+ UNUSED_TO_BE_DELETED2 = 2,
+ UNUSED_TO_BE_DELETED3 = 3,
+ RGB32 = 4, // 32bpp RGB packed with extra byte 8:8:8
+ UNUSED_TO_BE_DELETED5 = 5,
+ YV12 = 6, // 12bpp YVU planar 1x1 Y, 2x2 VU samples
+ YV16 = 7, // 16bpp YVU planar 1x1 Y, 2x1 VU samples
+ UNUSED_TO_BE_DELETED8 = 8,
+ EMPTY = 9, // An empty frame.
+ UNUSED_TO_BE_DELETED10 = 10,
+ I420 = 11, // 12bpp YVU planar 1x1 Y, 2x2 UV samples.
+ NATIVE_TEXTURE = 12, // Native texture. Pixel-format agnostic.
};
// Creates a new frame in system memory with given parameters. Buffers for
« no previous file with comments | « no previous file | media/base/video_frame.cc » ('j') | media/base/video_frame.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698