Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10024066: TabContents -> WebContentsImpl, part 4. (Closed)

Created:
8 years, 8 months ago by Avi (use Gerrit)
Modified:
8 years, 8 months ago
Reviewers:
jam
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, ajwong+watch_chromium.org, jam, dcheng, joi+watch-content_chromium.org, darin-cc_chromium.org, rdsmith+dwatch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

TabContents -> WebContentsImpl, part 4. BUG=105875 TEST=no change Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=131770

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -3961 lines) Patch
M chrome/browser/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tab_contents/native_tab_contents_view_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/debugger/devtools_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/save_package_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/intents/intent_injector_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/intents/internal_web_intents_dispatcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/test_render_view_host.cc View 1 chunk +1 line, -1 line 0 comments Download
D content/browser/tab_contents/popup_menu_helper_mac.h View 1 chunk +0 lines, -51 lines 0 comments Download
D content/browser/tab_contents/popup_menu_helper_mac.mm View 1 chunk +0 lines, -91 lines 0 comments Download
D content/browser/tab_contents/render_view_host_manager.h View 1 chunk +0 lines, -297 lines 0 comments Download
D content/browser/tab_contents/render_view_host_manager.cc View 1 chunk +0 lines, -839 lines 0 comments Download
D content/browser/tab_contents/render_view_host_manager_unittest.cc View 1 chunk +0 lines, -772 lines 0 comments Download
M content/browser/tab_contents/tab_contents.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
D content/browser/tab_contents/tab_contents_delegate_unittest.cc View 1 chunk +0 lines, -68 lines 0 comments Download
M content/browser/tab_contents/tab_contents_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/tab_contents_view_win.cc View 1 chunk +1 line, -1 line 0 comments Download
D content/browser/tab_contents/test_web_contents.h View 1 chunk +0 lines, -101 lines 0 comments Download
D content/browser/tab_contents/test_web_contents.cc View 1 chunk +0 lines, -181 lines 0 comments Download
D content/browser/tab_contents/web_contents_drag_win.h View 1 chunk +0 lines, -114 lines 0 comments Download
D content/browser/tab_contents/web_contents_drag_win.cc View 1 chunk +0 lines, -371 lines 0 comments Download
D content/browser/tab_contents/web_contents_view_android.h View 1 chunk +0 lines, -78 lines 0 comments Download
D content/browser/tab_contents/web_contents_view_android.cc View 1 chunk +0 lines, -166 lines 0 comments Download
D content/browser/tab_contents/web_contents_view_mac.h View 1 chunk +0 lines, -157 lines 0 comments Download
D content/browser/tab_contents/web_contents_view_mac.mm View 1 chunk +0 lines, -583 lines 0 comments Download
D content/browser/tab_contents/web_contents_view_mac_unittest.mm View 1 chunk +0 lines, -31 lines 0 comments Download
M content/browser/web_contents/navigation_controller_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/web_contents/popup_menu_helper_mac.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/web_contents/popup_menu_helper_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/web_contents/render_view_host_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/web_contents/render_view_host_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/web_contents/render_view_host_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/browser/web_contents/test_web_contents.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/web_contents/test_web_contents.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/web_contents/web_contents_delegate_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/web_contents/web_contents_drag_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/web_contents/web_contents_drag_win.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/web_contents/web_contents_view_android.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/web_contents/web_contents_view_android.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/web_contents/web_contents_view_mac.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/web_contents/web_contents_view_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
A + content/browser/web_contents/web_contents_view_mac_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_drag_dest_mac_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/content_browser.gypi View 4 chunks +12 lines, -12 lines 0 comments Download
M content/content_tests.gypi View 2 chunks +5 lines, -5 lines 0 comments Download
M content/test/test_renderer_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/web_contents_tester.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Avi (use Gerrit)
8 years, 8 months ago (2012-04-10 20:24:37 UTC) #1
jam
lgtm
8 years, 8 months ago (2012-04-10 21:27:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10024066/1
8 years, 8 months ago (2012-04-11 14:22:07 UTC) #3
commit-bot: I haz the power
8 years, 8 months ago (2012-04-11 14:22:29 UTC) #4 
Presubmit check for 10024066-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/ui

Presubmit checks took 2.8s to calculate.

Powered by Google App Engine
This is Rietveld 408576698