chrome/renderer/extensions/chrome_v8_context_set.cc - Issue 10024055: Remove unneeded extension_messages_browsertest.cc + cleanup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/chrome_v8_context_set.cc

Issue 10024055: Remove unneeded extension_messages_browsertest.cc + cleanup. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: windoooowze Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/extensions/chrome_v8_context_set.cc

diff --git a/chrome/renderer/extensions/chrome_v8_context_set.cc b/chrome/renderer/extensions/chrome_v8_context_set.cc

index e8ba257627f5a9f41131d286faae393289621543..b8531f8e81e8a0211a956203c7e510781b7bfb7b 100644

--- a/chrome/renderer/extensions/chrome_v8_context_set.cc

+++ b/chrome/renderer/extensions/chrome_v8_context_set.cc

@@ -117,8 +117,11 @@ void ChromeV8ContextSet::DispatchChromeHiddenMethod(

if ((*it)->v8_context().IsEmpty())

continue;

- if (!extension_id.empty() && extension_id != (*it)->extension_id())

- continue;

+ if (!extension_id.empty()) {

+ const Extension* extension = (*it)->extension();

+ if (!extension || (extension_id != extension->id()))

+ continue;

+ }

content::RenderView* context_render_view = (*it)->GetRenderView();

if (!context_render_view)