Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Unified Diff: chromeos/dbus/image_burner_client.cc

Issue 10024054: chromeos: Convert D-Bus client classes' callback arguments to const reference (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/dbus/image_burner_client.h ('k') | chromeos/dbus/mock_cashew_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/image_burner_client.cc
diff --git a/chromeos/dbus/image_burner_client.cc b/chromeos/dbus/image_burner_client.cc
index 343c02d0615f8ca6ca220bd4748426ad9d61031f..4119bf05854a1f469eec96f5d77aeafbe54ec823 100644
--- a/chromeos/dbus/image_burner_client.cc
+++ b/chromeos/dbus/image_burner_client.cc
@@ -45,7 +45,7 @@ class ImageBurnerClientImpl : public ImageBurnerClient {
// ImageBurnerClient override.
virtual void BurnImage(const std::string& from_path,
const std::string& to_path,
- ErrorCallback error_callback) OVERRIDE {
+ const ErrorCallback& error_callback) OVERRIDE {
dbus::MethodCall method_call(imageburn::kImageBurnServiceInterface,
imageburn::kBurnImage);
dbus::MessageWriter writer(&method_call);
@@ -59,8 +59,8 @@ class ImageBurnerClientImpl : public ImageBurnerClient {
// ImageBurnerClient override.
virtual void SetEventHandlers(
- BurnFinishedHandler burn_finished_handler,
- BurnProgressUpdateHandler burn_progress_update_handler) OVERRIDE {
+ const BurnFinishedHandler& burn_finished_handler,
+ const BurnProgressUpdateHandler& burn_progress_update_handler) OVERRIDE {
burn_finished_handler_ = burn_finished_handler;
burn_progress_update_handler_ = burn_progress_update_handler;
}
@@ -136,10 +136,10 @@ class ImageBurnerClientStubImpl : public ImageBurnerClient {
virtual ~ImageBurnerClientStubImpl() {}
virtual void BurnImage(const std::string& from_path,
const std::string& to_path,
- ErrorCallback error_callback) OVERRIDE {}
+ const ErrorCallback& error_callback) OVERRIDE {}
virtual void SetEventHandlers(
- BurnFinishedHandler burn_finished_handler,
- BurnProgressUpdateHandler burn_progress_update_handler) OVERRIDE {}
+ const BurnFinishedHandler& burn_finished_handler,
+ const BurnProgressUpdateHandler& burn_progress_update_handler) OVERRIDE {}
virtual void ResetEventHandlers() OVERRIDE {}
private:
« no previous file with comments | « chromeos/dbus/image_burner_client.h ('k') | chromeos/dbus/mock_cashew_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698