Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: chromeos/dbus/flimflam_client_unittest_base.h

Issue 10024054: chromeos: Convert D-Bus client classes' callback arguments to const reference (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/dbus/cryptohome_client.cc ('k') | chromeos/dbus/flimflam_client_unittest_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/flimflam_client_unittest_base.h
diff --git a/chromeos/dbus/flimflam_client_unittest_base.h b/chromeos/dbus/flimflam_client_unittest_base.h
index 9781fda9475c68cfb0a511793e7f5949d87592a5..3c88b27505c392d09cd80343f58bb89012a35cbb 100644
--- a/chromeos/dbus/flimflam_client_unittest_base.h
+++ b/chromeos/dbus/flimflam_client_unittest_base.h
@@ -47,7 +47,7 @@ class FlimflamClientUnittestBase : public testing::Test {
// Sets expectations for called method name and arguments, and sets response.
void PrepareForMethodCall(const std::string& method_name,
- ArgumentCheckCallback argument_checker,
+ const ArgumentCheckCallback& argument_checker,
dbus::Response* response);
// Sends property changed signal to the tested client.
@@ -95,14 +95,15 @@ class FlimflamClientUnittestBase : public testing::Test {
void OnConnectToSignal(
const std::string& interface_name,
const std::string& signal_name,
- dbus::ObjectProxy::SignalCallback signal_callback,
- dbus::ObjectProxy::OnConnectedCallback on_connected_callback);
+ const dbus::ObjectProxy::SignalCallback& signal_callback,
+ const dbus::ObjectProxy::OnConnectedCallback& on_connected_callback);
// Checks the content of the method call and returns the response.
// Used to implement the mock proxy.
- void OnCallMethod(dbus::MethodCall* method_call,
- int timeout_ms,
- dbus::ObjectProxy::ResponseCallback response_callback);
+ void OnCallMethod(
+ dbus::MethodCall* method_call,
+ int timeout_ms,
+ const dbus::ObjectProxy::ResponseCallback& response_callback);
// The interface name.
const std::string interface_name_;
« no previous file with comments | « chromeos/dbus/cryptohome_client.cc ('k') | chromeos/dbus/flimflam_client_unittest_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698