Metro/HiDPI: Move 1x icons into separate pak file

Metro/HiDPI: Move 1x icons into separate pak file

Currently all 1x art files are repacked into chrome.pak files.

This is a problem on Windows where we want to choose which pak file to load based on metro and DPI scale.

As a first step this CL does the following:
 - add a new enable_hidpi build flag. This allows us to test HiDPI mode on Windows Chrome.
 - stop packing theme_resources_standard.pak and ui_resources_standard.pak into chrome.pak
 - update the Mac and Windows installer code to package the extra pak files.

Note, I'll be updating the Linux installer script in a separate CL. I'm still looking into the ChromeOS situation.

BUG=114311
TEST=Ran on Windows, and Mac and Linux.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132517

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132760

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133613

[sky, 2012-04-12 00:29:27]

I'm replacing myself with Tony on this one too.

[Robert Sesek, 2012-04-12 14:08:40]

.mm LGTM

[sky, 2012-04-12 16:23:53]

LGTM

[robertshield, 2012-04-12 18:53:36]

lgtm

http://codereview.chromium.org/10024050/diff/9005/chrome/tools/build/win/rele...
File chrome/tools/build/win/release.rules (right):

http://codereview.chromium.org/10024050/diff/9005/chrome/tools/build/win/rele...
chrome/tools/build/win/release.rules:1: <?xml version="1.0" encoding="utf-8"?>
I'm not sure this file is needed - I don't see it directly referenced anywhere
in the gyp files. It might be though, so if you don't feel like shaving this
particular yak today, you can leave it be.

[Michael Moss, 2012-04-13 02:42:40]

You probably also need to add these files to the chrome/tools/build/*/FILES.cfg
files, to make sure they get archived from the official builders. See the
existing resources.pak entries for examples.

[sail, 2012-04-13 04:28:56]

On 2012/04/13 02:42:40, Michael Moss wrote:
> You probably also need to add these files to the
chrome/tools/build/*/FILES.cfg
> files, to make sure they get archived from the official builders. See the
> existing resources.pak entries for examples.

add the FILES.cfg changes. Could you take another look?

[Michael Moss, 2012-04-13 21:29:43]

LGTM.

Sorry for being slow, I missed your update.

[commit-bot: I haz the power, 2012-04-17 00:04:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/10024050/30006

[commit-bot: I haz the power, 2012-04-17 02:12:13]

Change committed as 132517

[commit-bot: I haz the power, 2012-04-18 04:28:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/10024050/22003

[commit-bot: I haz the power, 2012-04-18 07:30:23]

Change committed as 132760

[Nico, 2012-04-23 15:51:25]

Sorry for the delay, I was afk. Mac file lgtm, but one question about the
non-mac part.

http://codereview.chromium.org/10024050/diff/22003/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/10024050/diff/22003/build/common.gypi#newcode45
build/common.gypi:45: 'enable_hidpi%': 0,
Do you need to put this in the innermost variables dict? Having it one level
further down saves you one of the "copy variables out one scope" lines and might
be enough.

http://codereview.chromium.org/10024050/diff/22003/ui/base/resource/resource_...
File ui/base/resource/resource_bundle_mac.mm (right):

http://codereview.chromium.org/10024050/diff/22003/ui/base/resource/resource_...
ui/base/resource/resource_bundle_mac.mm:50: // On Windows and ChromeOS we load
either the 1x resource or the 2x resource.
How do you handle the case of a highdpi monitor being attached while chrome is
running on win/cros then?

[tony, 2012-04-26 18:16:31]

Can we merge ui_resources and theme_resources into the same pak file? 
Historically, we try to minimize the number of separate files we load from disk
because when the disk is cold, each additional file will result in an extra disk
seek (and slow startup).

Ideally, we would even merge these into an existing .pak file so we don't have
to open more files than before.

[sail, 2012-04-26 18:25:08]

On 2012/04/26 18:16:31, tony wrote:
> Can we merge ui_resources and theme_resources into the same pak file? 
> Historically, we try to minimize the number of separate files we load from
disk
> because when the disk is cold, each additional file will result in an extra
disk
> seek (and slow startup).
> 
> Ideally, we would even merge these into an existing .pak file so we don't have
> to open more files than before.

Hi Tony. I've filed http://crbug.com/125209 to track this.

Currently what you're suggesting isn't easy since ChromeOS has 3 copies of
ui_resources* (standard, 2x, and touch).

Once all the ChromeOS touch, ChromeOS high DPI, and Metro high DPI work has
landed I'll come back and combine all the resource paks that I can.

Thanks