Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
10024045:
Add support for launching windows ninja from cygwin. (Closed)
DescriptionAdd support for launching windows ninja from cygwin.
Shell through to the .bat to make sure the environment is correctly set up. Not sure if there's a better uname to check?
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132252
Patch Set 1 #
Total comments: 6
Patch Set 2 : #Messages
Total messages: 7 (0 generated)
lgtm with comments http://chromiumcodereview.appspot.com/10024045/diff/1/ninja File ninja (right): http://chromiumcodereview.appspot.com/10024045/diff/1/ninja#newcode1 ninja:1: #!/bin/bash copyright header http://chromiumcodereview.appspot.com/10024045/diff/1/ninja#newcode9 ninja:9: elif [ "${OS}" = "CYGWIN_NT-6.1-WOW64" ]; then Strictly speaking, WOW64 is not guaranteed but in practice, it's going to be there. Can you do a proper "startswith" with [? http://chromiumcodereview.appspot.com/10024045/diff/1/ninja#newcode10 ninja:10: exec cmd /c `cygpath -t windows $0`.bat "$@" cmd.exe
Thanks. Scott, let me know if you still have cygwin trouble. http://chromiumcodereview.appspot.com/10024045/diff/1/ninja File ninja (right): http://chromiumcodereview.appspot.com/10024045/diff/1/ninja#newcode1 ninja:1: #!/bin/bash On 2012/04/13 20:09:19, Marc-Antoine Ruel wrote: > copyright header Done. http://chromiumcodereview.appspot.com/10024045/diff/1/ninja#newcode9 ninja:9: elif [ "${OS}" = "CYGWIN_NT-6.1-WOW64" ]; then On 2012/04/13 20:09:19, Marc-Antoine Ruel wrote: > Strictly speaking, WOW64 is not guaranteed but in practice, it's going to be > there. Can you do a proper "startswith" with [? Done. http://chromiumcodereview.appspot.com/10024045/diff/1/ninja#newcode10 ninja:10: exec cmd /c `cygpath -t windows $0`.bat "$@" On 2012/04/13 20:09:19, Marc-Antoine Ruel wrote: > cmd.exe Done.
Working, thanks. (As for output, I force TERM to ansi and let Emacs fix up the output on other platforms - I can pull ninja and submit a patch myself if you don't want to bother). On Fri, Apr 13, 2012 at 1:17 PM, <scottmg@chromium.org> wrote: > Thanks. Scott, let me know if you still have cygwin trouble. > > > > http://chromiumcodereview.**appspot.com/10024045/diff/1/**ninja<http://chromi... > File ninja (right): > > http://chromiumcodereview.**appspot.com/10024045/diff/1/**ninja#newcode1<http... > ninja:1: #!/bin/bash > On 2012/04/13 20:09:19, Marc-Antoine Ruel wrote: > >> copyright header >> > > Done. > > > http://chromiumcodereview.**appspot.com/10024045/diff/1/**ninja#newcode9<http... > ninja:9: elif [ "${OS}" = "CYGWIN_NT-6.1-WOW64" ]; then > On 2012/04/13 20:09:19, Marc-Antoine Ruel wrote: > >> Strictly speaking, WOW64 is not guaranteed but in practice, it's going >> > to be > >> there. Can you do a proper "startswith" with [? >> > > Done. > > > http://chromiumcodereview.**appspot.com/10024045/diff/1/**ninja#newcode10<htt... > ninja:10: exec cmd /c `cygpath -t windows $0`.bat "$@" > On 2012/04/13 20:09:19, Marc-Antoine Ruel wrote: > >> cmd.exe >> > > Done. > > http://chromiumcodereview.**appspot.com/10024045/<http://chromiumcodereview.a... >
How do you force to ansi? I don't use cygwin or Emacs, so perhaps it'd be more for you to submit a patch if there's something to be fixed in ninja proper. On Fri, Apr 13, 2012 at 1:23 PM, Scott Byer <scottbyer@chromium.org> wrote: > Working, thanks. > > (As for output, I force TERM to ansi and let Emacs fix up the output on > other platforms - I can pull ninja and submit a patch myself if you don't > want to bother). > > > On Fri, Apr 13, 2012 at 1:17 PM, <scottmg@chromium.org> wrote: >> >> Thanks. Scott, let me know if you still have cygwin trouble. >> >> >> >> http://chromiumcodereview.appspot.com/10024045/diff/1/ninja >> File ninja (right): >> >> http://chromiumcodereview.appspot.com/10024045/diff/1/ninja#newcode1 >> ninja:1: #!/bin/bash >> On 2012/04/13 20:09:19, Marc-Antoine Ruel wrote: >>> >>> copyright header >> >> >> Done. >> >> >> http://chromiumcodereview.appspot.com/10024045/diff/1/ninja#newcode9 >> ninja:9: elif [ "${OS}" = "CYGWIN_NT-6.1-WOW64" ]; then >> On 2012/04/13 20:09:19, Marc-Antoine Ruel wrote: >>> >>> Strictly speaking, WOW64 is not guaranteed but in practice, it's going >> >> to be >>> >>> there. Can you do a proper "startswith" with [? >> >> >> Done. >> >> >> http://chromiumcodereview.appspot.com/10024045/diff/1/ninja#newcode10 >> ninja:10: exec cmd /c `cygpath -t windows $0`.bat "$@" >> On 2012/04/13 20:09:19, Marc-Antoine Ruel wrote: >>> >>> cmd.exe >> >> >> Done. >> >> http://chromiumcodereview.appspot.com/10024045/ > >
er, "more effective" On Fri, Apr 13, 2012 at 1:25 PM, Scott Graham <scottmg@chromium.org> wrote: > How do you force to ansi? I don't use cygwin or Emacs, so perhaps it'd > be more for you to submit a patch if there's something to be fixed in > ninja proper. > > On Fri, Apr 13, 2012 at 1:23 PM, Scott Byer <scottbyer@chromium.org> wrote: >> Working, thanks. >> >> (As for output, I force TERM to ansi and let Emacs fix up the output on >> other platforms - I can pull ninja and submit a patch myself if you don't >> want to bother). >> >> >> On Fri, Apr 13, 2012 at 1:17 PM, <scottmg@chromium.org> wrote: >>> >>> Thanks. Scott, let me know if you still have cygwin trouble. >>> >>> >>> >>> http://chromiumcodereview.appspot.com/10024045/diff/1/ninja >>> File ninja (right): >>> >>> http://chromiumcodereview.appspot.com/10024045/diff/1/ninja#newcode1 >>> ninja:1: #!/bin/bash >>> On 2012/04/13 20:09:19, Marc-Antoine Ruel wrote: >>>> >>>> copyright header >>> >>> >>> Done. >>> >>> >>> http://chromiumcodereview.appspot.com/10024045/diff/1/ninja#newcode9 >>> ninja:9: elif [ "${OS}" = "CYGWIN_NT-6.1-WOW64" ]; then >>> On 2012/04/13 20:09:19, Marc-Antoine Ruel wrote: >>>> >>>> Strictly speaking, WOW64 is not guaranteed but in practice, it's going >>> >>> to be >>>> >>>> there. Can you do a proper "startswith" with [? >>> >>> >>> Done. >>> >>> >>> http://chromiumcodereview.appspot.com/10024045/diff/1/ninja#newcode10 >>> ninja:10: exec cmd /c `cygpath -t windows $0`.bat "$@" >>> On 2012/04/13 20:09:19, Marc-Antoine Ruel wrote: >>>> >>>> cmd.exe >>> >>> >>> Done. >>> >>> http://chromiumcodereview.appspot.com/10024045/ >> >>
In my .bashrc, I've got [ -n "$INSIDE_EMACS" ] && export TERM=ansi Yes, it needs to be fixed in ninja proper - I'll take care of it. On Fri, Apr 13, 2012 at 1:26 PM, Scott Graham <scottmg@chromium.org> wrote: > er, "more effective" > > On Fri, Apr 13, 2012 at 1:25 PM, Scott Graham <scottmg@chromium.org> > wrote: > > How do you force to ansi? I don't use cygwin or Emacs, so perhaps it'd > > be more for you to submit a patch if there's something to be fixed in > > ninja proper. > > > > On Fri, Apr 13, 2012 at 1:23 PM, Scott Byer <scottbyer@chromium.org> > wrote: > >> Working, thanks. > >> > >> (As for output, I force TERM to ansi and let Emacs fix up the output on > >> other platforms - I can pull ninja and submit a patch myself if you > don't > >> want to bother). > >> > >> > >> On Fri, Apr 13, 2012 at 1:17 PM, <scottmg@chromium.org> wrote: > >>> > >>> Thanks. Scott, let me know if you still have cygwin trouble. > >>> > >>> > >>> > >>> http://chromiumcodereview.appspot.com/10024045/diff/1/ninja > >>> File ninja (right): > >>> > >>> http://chromiumcodereview.appspot.com/10024045/diff/1/ninja#newcode1 > >>> ninja:1: #!/bin/bash > >>> On 2012/04/13 20:09:19, Marc-Antoine Ruel wrote: > >>>> > >>>> copyright header > >>> > >>> > >>> Done. > >>> > >>> > >>> http://chromiumcodereview.appspot.com/10024045/diff/1/ninja#newcode9 > >>> ninja:9: elif [ "${OS}" = "CYGWIN_NT-6.1-WOW64" ]; then > >>> On 2012/04/13 20:09:19, Marc-Antoine Ruel wrote: > >>>> > >>>> Strictly speaking, WOW64 is not guaranteed but in practice, it's going > >>> > >>> to be > >>>> > >>>> there. Can you do a proper "startswith" with [? > >>> > >>> > >>> Done. > >>> > >>> > >>> http://chromiumcodereview.appspot.com/10024045/diff/1/ninja#newcode10 > >>> ninja:10: exec cmd /c `cygpath -t windows $0`.bat "$@" > >>> On 2012/04/13 20:09:19, Marc-Antoine Ruel wrote: > >>>> > >>>> cmd.exe > >>> > >>> > >>> Done. > >>> > >>> http://chromiumcodereview.appspot.com/10024045/ > >> > >> > |
