Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: src/trusted/validator/x86/32/ncvalidate_verbose.c

Issue 10024039: Replace kind variable from validator API with Boolean stubout parameter. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: Final edits Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/trusted/validator/x86/32/ncvalidate.c ('k') | src/trusted/validator/x86/64/ncvalidate.c » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/trusted/validator/x86/32/ncvalidate_verbose.c
diff --git a/src/trusted/validator/x86/32/ncvalidate_verbose.c b/src/trusted/validator/x86/32/ncvalidate_verbose.c
index 9a0900ae3b1f15bc769328d6b403d37678f46138..a9f2e77b64b1879c1a229038540a8685c2d36408 100644
--- a/src/trusted/validator/x86/32/ncvalidate_verbose.c
+++ b/src/trusted/validator/x86/32/ncvalidate_verbose.c
@@ -47,7 +47,6 @@ static NaClValidationStatus NCApplyValidatorVerbosely_x86_32(
NaClValidationStatus NACL_SUBARCH_NAME(ApplyValidatorVerbosely, x86, 32)
(enum NaClSBKind sb_kind,
- NaClApplyValidationKind kind,
uintptr_t guest_addr,
uint8_t *data,
size_t size,
@@ -58,19 +57,8 @@ NaClValidationStatus NACL_SUBARCH_NAME(ApplyValidatorVerbosely, x86, 32)
if (bundle_size == 16 || bundle_size == 32) {
if (!NaClArchSupported(cpu_features))
return NaClValidationFailedCpuNotSupported;
- switch (kind) {
- case NaClApplyCodeValidation:
- status = NCApplyValidatorVerbosely_x86_32(
- guest_addr, data, size, bundle_size, cpu_features);
- break;
- case NaClApplyValidationDoStubout:
- status = NCApplyValidatorStubout_x86_32(
- guest_addr, data, size, bundle_size, cpu_features);
- break;
- default:
- /* If reached, it isn't implemented (yet). */
- break;
- }
+ status = NCApplyValidatorVerbosely_x86_32(
+ guest_addr, data, size, bundle_size, cpu_features);
}
return status;
}
« no previous file with comments | « src/trusted/validator/x86/32/ncvalidate.c ('k') | src/trusted/validator/x86/64/ncvalidate.c » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698