Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: src/tools/validator_tools/ncstubout.c

Issue 10024039: Replace kind variable from validator API with Boolean stubout parameter. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: Edits Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/tools/validator_tools/ncstubout.c
diff --git a/src/tools/validator_tools/ncstubout.c b/src/tools/validator_tools/ncstubout.c
index f167df8c7629ef17cc2faadaa0791d89f2c412a8..a5f4b22147ed68020a305ef4c898644ddc0c33c9 100644
--- a/src/tools/validator_tools/ncstubout.c
+++ b/src/tools/validator_tools/ncstubout.c
@@ -39,8 +39,9 @@ static Bool FixUpSection(uintptr_t load_address,
status = NACL_SUBARCH_NAME(ApplyValidator,
NACL_TARGET_ARCH,
NACL_TARGET_SUBARCH)
- (sb_kind, NaClApplyValidationDoStubout, load_address, code,
- code_size, bundle_size, FALSE, &cpu_features, NULL);
+ (sb_kind, load_address, code, code_size, bundle_size,
+ /* stubout_mode= */ TRUE, /* readonly_text= */ FALSE,
+ &cpu_features, NULL);
if (status == NaClValidationSucceeded) {
/* Now run the validator again, so that we report any errors
* that were not fixed by stubbing out. This is done so that
@@ -49,8 +50,7 @@ static Bool FixUpSection(uintptr_t load_address,
status = NACL_SUBARCH_NAME(ApplyValidatorVerbosely,
NACL_TARGET_ARCH,
NACL_TARGET_SUBARCH)
- (sb_kind, NaClApplyCodeValidation, load_address, code, code_size,
- bundle_size, &cpu_features);
+ (sb_kind, load_address, code, code_size, bundle_size, &cpu_features);
}
switch (status) {
« no previous file with comments | « no previous file | src/trusted/service_runtime/sel_validate_image.c » ('j') | src/trusted/service_runtime/sel_validate_image.c » ('J')

Powered by Google App Engine
This is Rietveld 408576698