Issue 10024025: Use ScopedRefNPObject to pass NPObjects in the host plugin.

Issue 10024025: Use ScopedRefNPObject to pass NPObjects in the host plugin. (Closed)

Created:
8 years, 8 months ago by Sergey Ulanov

Modified:
8 years, 8 months ago

Reviewers:
Jamie

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use ScopedRefNPObject to pass NPObjects in the host plugin. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=131489

Patch Set 1 : #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -37 lines)			Patch
M	remoting/host/plugin/host_plugin_utils.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	remoting/host/plugin/host_plugin_utils.cc	View	1 2	2 chunks	+10 lines, -0 lines	0 comments	Download
M	remoting/host/plugin/host_script_object.h	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	remoting/host/plugin/host_script_object.cc	View	1	11 chunks	+17 lines, -30 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10024025/5001

8 years, 8 months ago (2012-04-09 19:47:23 UTC) #3

Wez

http://codereview.chromium.org/10024025/diff/5001/remoting/host/plugin/host_plugin_utils.cc File remoting/host/plugin/host_plugin_utils.cc (right): http://codereview.chromium.org/10024025/diff/5001/remoting/host/plugin/host_plugin_utils.cc#newcode52 remoting/host/plugin/host_plugin_utils.cc:52: *this = object.get(); nit: Do you need get() here, ...

8 years, 8 months ago (2012-04-09 20:00:50 UTC) #4

Sergey Ulanov

8 years, 8 months ago (2012-04-09 20:06:32 UTC) #5

commit-bot: I haz the power

Commit queue failed due to new patchset.

8 years, 8 months ago (2012-04-09 21:21:05 UTC) #6

commit-bot: I haz the power

8 years, 8 months ago (2012-04-09 21:21:15 UTC) #7

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10024025/2007

Expand Messages | Collapse Messages