Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 10021048: Remove need to instantiate Platform and make methods static. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Add stable test binaries. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/test_runner.dart ('k') | utils/compiler/build_helper.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index 7d7fed01018ba92d641931adada26b5ba307a09f..cf9c46783f3ba210e94a0cb3e14e1efce4dabf1c 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -565,7 +565,7 @@ class StandardTestSuite implements TestSuite {
// Create the HTML file for the test.
RandomAccessFile htmlTest = new File(htmlPath).openSync(FileMode.WRITE);
String filePrefix = '';
- if (new Platform().operatingSystem() == 'windows') {
+ if (Platform.operatingSystem() == 'windows') {
// Firefox on Windows does not like absolute file path names that start
// with 'C:' adding 'file:///' solves the problem.
filePrefix = 'file:///';
@@ -777,7 +777,7 @@ class StandardTestSuite implements TestSuite {
if (configuration['drt'] != '') {
return configuration['drt'];
}
- if (new Platform().operatingSystem() == 'macos') {
+ if (Platform.operatingSystem() == 'macos') {
return '$dartDir/client/tests/drt/DumpRenderTree.app/Contents/'
'MacOS/DumpRenderTree';
}
@@ -788,7 +788,7 @@ class StandardTestSuite implements TestSuite {
if (configuration['dartium'] != '') {
return configuration['dartium'];
}
- if (new Platform().operatingSystem() == 'macos') {
+ if (Platform.operatingSystem() == 'macos') {
return '$dartDir/client/tests/dartium/Chromium.app/Contents/'
'MacOS/Chromium';
}
@@ -1221,7 +1221,7 @@ class TestUtils {
}
static String executableSuffix(String executable) {
- if (new Platform().operatingSystem() == 'windows') {
+ if (Platform.operatingSystem() == 'windows') {
if (executable == 'd8' || executable == 'vm' || executable == 'none') {
return '.exe';
} else {
« no previous file with comments | « tools/testing/dart/test_runner.dart ('k') | utils/compiler/build_helper.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698