Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2252)

Unified Diff: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionEngine.java

Issue 10021017: Adds parser recovery for type parameters and type arguments (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updates for completion to work Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionEngine.java
diff --git a/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionEngine.java b/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionEngine.java
index 98cbc671c372bd32deee53112d92495c8da051c2..305db80a893336320a3af8664ea7d9e7b881eff8 100644
--- a/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionEngine.java
+++ b/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionEngine.java
@@ -1,11 +1,11 @@
/*
* Copyright (c) 2012, the Dart project authors.
- *
+ *
* Licensed under the Eclipse Public License v1.0 (the "License"); you may not use this file except
* in compliance with the License. You may obtain a copy of the License at
- *
+ *
* http://www.eclipse.org/legal/epl-v10.html
- *
+ *
* Unless required by applicable law or agreed to in writing, software distributed under the License
* is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
* or implied. See the License for the specific language governing permissions and limitations under
@@ -655,6 +655,7 @@ public class CompletionEngine {
@Override
public Void visitFunctionTypeAlias(DartFunctionTypeAlias node) {
+ node.visitChildren(this);
return null;
}
@@ -693,7 +694,7 @@ public class CompletionEngine {
DartNode target = completionNode.getTarget();
if (target instanceof DartPropertyAccess) {
// TODO(zundel): HACK! This might be a 'this' or 'static' access: I didn't check
- createCompletionsForPropertyAccess(((DartPropertyAccess) target).getName(),
+ createCompletionsForPropertyAccess(((DartPropertyAccess) target).getName(),
analyzeType(target), false, false);
}
}
@@ -790,7 +791,7 @@ public class CompletionEngine {
if (qualifier instanceof DartIdentifier) {
name = (DartIdentifier)qualifier;
} else {
- name = ((DartPropertyAccess)qualifier).getName();
+ name = ((DartPropertyAccess)qualifier).getName();
}
Element element = name.getElement();
ScopedNameFinder vars = new ScopedNameFinder(actualCompletionPosition);
@@ -854,6 +855,11 @@ public class CompletionEngine {
DartPropertyAccess prop = (DartPropertyAccess) completionNode.getParent();
prop.accept(new IdentifierCompletionProposer(prop.getName()));
}
+ } else if (completionNode.getParent() instanceof DartTypeParameter) {
+ // < T extends !>
+ if (completionNode.getIdentifier() instanceof DartIdentifier) {
+ proposeTypeNamesForPrefix((DartIdentifier)completionNode.getIdentifier());
+ }
}
}
return null;
@@ -876,6 +882,7 @@ public class CompletionEngine {
}
}
}
+ node.visitChildren(this);
return null;
}

Powered by Google App Engine
This is Rietveld 408576698