Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7192)

Unified Diff: chrome/chrome_tests.gypi

Issue 10021014: mac: Remove explicit dependency from chrome_app_unittests on webcore. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_tests.gypi
diff --git a/chrome/chrome_tests.gypi b/chrome/chrome_tests.gypi
index 8d683c0c3e5e00d559131b116091e1e377183254..2c01070d5d20a1cad2be485f36a90322a82d1021 100644
--- a/chrome/chrome_tests.gypi
+++ b/chrome/chrome_tests.gypi
@@ -2577,28 +2577,6 @@
# but when we tried to pull it up to the common.gypi level, it broke
# other things like the ui, startup, and page_cycler tests. *shrug*
'xcode_settings': {'OTHER_LDFLAGS': ['-Wl,-ObjC']},
-
- # libwebcore.a is so large that ld may not have a sufficiently large
- # "hole" in its address space into which it can be mmaped by the
- # time it reaches this library. As of May 10, 2010, libwebcore.a is
- # about 1GB in some builds. In the Mac OS X 10.5 toolchain, using
- # Xcode 3.1, ld is only a 32-bit executable, and address space
- # exhaustion is the result, with ld failing and producing
- # the message:
- # ld: in .../libwebcore.a, can't map file, errno=12
- #
- # As a workaround, ensure that libwebcore.a appears to ld first when
- # linking unit_tests. This allows the library to be mmapped when
- # ld's address space is "wide open." Other libraries are small
- # enough that they'll be able to "squeeze" into the remaining holes.
- # The Mac linker isn't so sensitive that moving this library to the
- # front of the list will cause problems.
- #
- # Enough pluses to make this target get prepended to the target's
- # list of dependencies.
- 'dependencies+++': [
- '../third_party/WebKit/Source/WebCore/WebCore.gyp/WebCore.gyp:webcore',
- ],
}],
['OS=="win"', {
'dependencies': [
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698