Issue 10021014: mac: Remove explicit dependency from chrome_app_unittests on webcore.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10021014: mac: Remove explicit dependency from chrome_app_unittests on webcore. (Closed)

Created:
8 years, 8 months ago by Nico

Modified:
8 years, 8 months ago

Reviewers:
MAD

CC:
chromium-reviews, robertshield

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

mac: Remove explicit dependency from chrome_app_unittests on webcore. I removed that dependency from all test targets in http://codereview.chromium.org/9700055, but http://codereview.chromium.org/9432033/ added the new test target chrome_app_unittests with the bad dependency. BUG=43791, 90078 TEST=things still build, the macshared bot on the fyi waterfall goes green again TBR=mad Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=131284

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -22 lines)			Patch
	M	chrome/chrome_tests.gypi	View		1 chunk	+0 lines, -22 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10021014/1

8 years, 8 months ago (2012-04-07 17:06:35 UTC) #2

MAD

8 years, 8 months ago (2012-04-12 13:32:35 UTC) #3

On 2012/04/07 17:06:35, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
> https://chromium-status.appspot.com/cq/thakis%40chromium.org/10021014/1

Oups... sorry about that... Didn't notice... :-(

LGTM

Expand Messages | Collapse Messages