Reland r131019: Move most TemplateURL data members to a new struct, TemplateURLData. This allows us…

Reland r131019: Move most TemplateURL data members to a new struct, TemplateURLData. This allows us to eliminate the TemplateURL NULL constructor, most public non-const TemplateURL functions, and most TemplateURL friend declarations.

This is also a necessary precursor to changing TemplateURLService's APIs to convert most "const TemplateURL*" cases to "TemplateURL*", which I'll explain once I actually make the change.

There is some awkwardness here around keywords, as keyword autogeneration requires a TemplateURL but the state bits are kept on TemplateURLData. This will go away in the future when I remove keyword autogeneration from TemplateURL entirely.

This differs from r131019 in that it fixes a memory error in chrome/browser/search_engines/util.cc:MergeEnginesFromPrepopulateData() where when we updated the vector to contain a new TemplateURL*, we didn't also update |default_search_engine| to point at the new URL if necessary.

BUG=none
TEST=none
TBR=sky,mnissler,atwilson
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=131224

[Peter Kasting, 2012-04-07 01:29:54]

Sending TBR because except for a memory error fix and a few cosmetic changes in
template_url_service.cc, this is the same patch you already reviewed in
https://chromiumcodereview.appspot.com/9982018/ .

[Mattias Nissler (ping if slow), 2012-04-10 09:38:09]

lgtm