Issue 10020028: Merge 130722 - On ChromeOS, the user is always signed in and we should not

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10020028: Merge 130722 - On ChromeOS, the user is always signed in and we should not (Closed)

Created:
8 years, 8 months ago by kochi

Modified:
8 years, 8 months ago

Reviewers:
Takayoshi Kochi (Google)

CC:
chromium-reviews, Raghu Simha, ncarter (slow), arv (Not doing code reviews), akalin, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/branches/1084/src/

Visibility:
Public.

Merge 130722 - On ChromeOS, the user is always signed in and we should not show user/password dialog when re-enabling sync. BUG=chromium-os:27955, chromium-os:27956, chromium:121563 TEST=manual, unit_tests --gtest_filter="*Sync*" Review URL: https://chromiumcodereview.appspot.com/9956097 TBR=kochi@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=131687

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+183 lines, -17 lines)			Patch
M	chrome/browser/resources/sync_setup_overlay.html	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/sync_setup_overlay.js	View	3 chunks	+10 lines, -1 line	0 comments	Download
M	chrome/browser/signin/signin_tracker.h	View	3 chunks	+10 lines, -7 lines	0 comments	Download
M	chrome/browser/signin/signin_tracker.cc	View	3 chunks	+20 lines, -6 lines	0 comments	Download
M	chrome/browser/signin/signin_tracker_unittest.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service.cc	View	4 chunks	+28 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/sync_prefs.h	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/sync_prefs.cc	View	2 chunks	+18 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/sync_setup_handler.h	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/sync_setup_handler.cc	View	6 chunks	+44 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/sync_setup_handler_unittest.cc	View	9 chunks	+13 lines, -0 lines	0 comments	Download
M	chrome/common/pref_names.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/pref_names.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 1 (0 generated)