Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 10019012: Fix MinGW-w64 GCC 4.7 compilation (Closed)

Created:
8 years, 8 months ago by Net147
Modified:
8 years, 8 months ago
Reviewers:
ulan, Yang
CC:
v8-dev
Visibility:
Public.

Description

Fix MinGW-w64 GCC 4.7 compilation Contributed by net147@gmail.com BUGS= TEST= Committed: https://code.google.com/p/v8/source/detail?r=11357

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -17 lines) Patch
M src/platform-win32.cc View 1 3 chunks +17 lines, -17 lines 0 comments Download
M test/cctest/test-disasm-x64.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Net147
8 years, 8 months ago (2012-04-08 13:41:27 UTC) #1
Yang
On 2012/04/08 13:41:27, Net147 wrote: LGTM, landing.
8 years, 8 months ago (2012-04-17 13:34:55 UTC) #2
Yang
Just noticed something. I will land this patch after this question has been cleared. https://chromiumcodereview.appspot.com/10019012/diff/6003/test/cctest/test-disasm-x64.cc ...
8 years, 8 months ago (2012-04-17 13:37:19 UTC) #3
Net147
https://chromiumcodereview.appspot.com/10019012/diff/6003/test/cctest/test-disasm-x64.cc File test/cctest/test-disasm-x64.cc (right): https://chromiumcodereview.appspot.com/10019012/diff/6003/test/cctest/test-disasm-x64.cc#newcode267 test/cctest/test-disasm-x64.cc:267: (void) after_break_target; On 2012/04/17 13:37:19, Yang wrote: > What ...
8 years, 8 months ago (2012-04-17 14:25:01 UTC) #4
Yang
On 2012/04/17 14:25:01, Net147 wrote: > https://chromiumcodereview.appspot.com/10019012/diff/6003/test/cctest/test-disasm-x64.cc > File test/cctest/test-disasm-x64.cc (right): > > https://chromiumcodereview.appspot.com/10019012/diff/6003/test/cctest/test-disasm-x64.cc#newcode267 > ...
8 years, 8 months ago (2012-04-17 14:32:43 UTC) #5
Net147
On 2012/04/17 14:32:43, Yang wrote: > On 2012/04/17 14:25:01, Net147 wrote: > > > https://chromiumcodereview.appspot.com/10019012/diff/6003/test/cctest/test-disasm-x64.cc ...
8 years, 8 months ago (2012-04-17 14:38:09 UTC) #6
Yang
8 years, 8 months ago (2012-04-17 15:04:40 UTC) #7
On 2012/04/17 14:38:09, Net147 wrote:
> On 2012/04/17 14:32:43, Yang wrote:
> > On 2012/04/17 14:25:01, Net147 wrote:
> > >
> >
>
https://chromiumcodereview.appspot.com/10019012/diff/6003/test/cctest/test-di...
> > > File test/cctest/test-disasm-x64.cc (right):
> > > 
> > >
> >
>
https://chromiumcodereview.appspot.com/10019012/diff/6003/test/cctest/test-di...
> > > test/cctest/test-disasm-x64.cc:267: (void) after_break_target;
> > > On 2012/04/17 13:37:19, Yang wrote:
> > > > What is this for?
> > > 
> > > I get a compiler error because it thinks this variable is never used.
> > 
> > Unfortunately, this sort of cast violates the Google code style:
> > http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Casting
> > 
> > Maybe you can take advantage of the USE(x) template in globals.h?
> 
> Updated.

Landed as r11357.

Powered by Google App Engine
This is Rietveld 408576698