Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Unified Diff: lib/dom/scripts/systemnative.py

Issue 10014028: Remove EventListener attributes from Dart DOM API. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Create real IDLParentInterface. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/dom/scripts/systemnative.py
diff --git a/lib/dom/scripts/systemnative.py b/lib/dom/scripts/systemnative.py
index 4ecb8a9eac70e7780bfa8ae057614df2a03bdd73..50538c10babb63b7237f1b8b8884b11398a11b61 100644
--- a/lib/dom/scripts/systemnative.py
+++ b/lib/dom/scripts/systemnative.py
@@ -439,13 +439,6 @@ class NativeImplementationGenerator(systemwrapping.WrappingInterfaceGenerator):
return False
def AddAttribute(self, getter, setter):
- # FIXME: Dartium does not support attribute event listeners. However, JS
- # implementation falls back to them when addEventListener is not available.
- # Make sure addEventListener is available in all EventTargets and remove
- # this check.
- if (getter or setter).type.id == 'EventListener':
- return
-
if 'CheckSecurityForNode' in (getter or setter).ext_attrs:
# FIXME: exclude from interface as well.
return

Powered by Google App Engine
This is Rietveld 408576698