Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 10014007: Change 9789001: attempt #3 after fixing the problems with linux Created by Wei Li: https://chromium… (Closed)

Created:
8 years, 8 months ago by GeorgeY
Modified:
8 years, 8 months ago
Reviewers:
Wei Li, brettw
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Change 9789001: attempt #3 after fixing the problems with linux Created by Wei Li: https://chromiumcodereview.appspot.com/9789001/ Changes to add duration into history database. This completes Issue 9605037 which can compute suggestion sites based on time slicing as well as visit duration. A new database table was added for those new fields we may need to experiment on. Warning: HistoryBackendTest.MigrationVisitDuration and HistoryProfileTest.TypicalProfileVersion are failing on the bots because of bots inability to update binary files. Once committed everything should be fine. BUG=none TEST=unit-tests TBR=brettw@chromium.org,weili@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=131473

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+271 lines, -12 lines) Patch
M chrome/browser/history/archived_database.h View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/history/archived_database.cc View 4 chunks +18 lines, -2 lines 0 comments Download
M chrome/browser/history/history.h View 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/history/history.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/history/history_backend.h View 3 chunks +17 lines, -2 lines 0 comments Download
M chrome/browser/history/history_backend.cc View 3 chunks +29 lines, -0 lines 0 comments Download
M chrome/browser/history/history_backend_unittest.cc View 1 chunk +115 lines, -0 lines 0 comments Download
M chrome/browser/history/history_database.cc View 2 chunks +12 lines, -1 line 0 comments Download
M chrome/browser/history/history_tab_helper.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/history/history_tab_helper.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M chrome/browser/history/history_types.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/history/visit_database.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/history/visit_database.cc View 7 chunks +30 lines, -8 lines 0 comments Download
A chrome/test/data/History/ArchivedNoDuration View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/test/data/History/HistoryNoDuration View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/test/data/profiles/typical_history/Default/History View 0 chunks +-1 lines, --1 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698