Don't recreate background windows when allow_js_access if false

chrome/test/data/extensions/api_test/app_background_page/no_js/test.js

Index: chrome/test/data/extensions/api_test/app_background_page/no_js/test.js
diff --git a/chrome/test/data/extensions/api_test/app_background_page/no_js/test.js b/chrome/test/data/extensions/api_test/app_background_page/no_js/test.js
index fd42f0740db00e00c66dc64e8316f48848e61a64..c26ec7ae48d38b9bd86914ac48fbb1caeeee79ee 100644
--- a/chrome/test/data/extensions/api_test/app_background_page/no_js/test.js
+++ b/chrome/test/data/extensions/api_test/app_background_page/no_js/test.js
@@ -7,9 +7,14 @@
 //   AppBackgroundPageApiTest.NoJsBackgroundPage code).
 // - The return value of the window.open call is null (since the background
 //   page is not scriptable)
+// - Attempts to call window.open(...., "background") again will not result in
+//   existing background page being closed and a new one being re-opened.
 
 var pagePrefix =
     'http://a.com:PORT/files/extensions/api_test/app_background_page/no_js';
+var launchUrl;
+var launchTabId;
+var backgroundPageLoaded = false;
 
 // Dispatch "tunneled" functions from the live web pages to this testing page.
 chrome.extension.onRequest.addListener(function(request) {
@@ -33,9 +38,13 @@ window.onload = function() {
   // config is requested before onload, then sometimes onload has already
   // fired by the time chrome.test.getConfig()'s callback runs.
   chrome.test.getConfig(function(config) {
-    var launchUrl =
+    launchUrl =
         pagePrefix.replace(/PORT/, config.testServer.port) + '/launch.html';
-    chrome.tabs.create({ 'url': launchUrl });
+    chrome.tabs.create(
+        {url: launchUrl},
+        function(tab) {
+            launchTabId = tab.id;
+        });
   });
 }
 
@@ -44,5 +53,25 @@ function onBackgroundWindowNotNull() {
 }
 
 function onBackgroundPageLoaded() {
-  chrome.test.notifyPass();
+  if (backgroundPageLoaded) {
+  chrome.test.notifyFail('Background page loaded more than once.');

[Charlie Reis, 2012/04/06 21:55:24]

nit: indent

[Mihai Parparita -not on Chrome, 2012/04/06 22:22:09]

Fixed.

+    return;
+  }
+
+  backgroundPageLoaded = true;
+
+  // Close the existing page and re-open it, which will try to call
+  // window.open(..., "background") again.
+  chrome.tabs.remove(
+      launchTabId,
+      function() {
+        chrome.tabs.create(
+            {url: launchUrl },
+            function(tab) {
+              // We wait for a bit before declaring the test as passed, since

[Mihai Parparita -not on Chrome, 2012/04/06 21:10:05]

This is kind of lame, but I don't have any other ideas for making this more
testable (except for making MaybeCreateBackgroundContents send a notification
when it ignores the window.open request, but I'm not sure if a test-only
notification is appropriate).

[Charlie Reis, 2012/04/06 21:55:24]

Yeah, this is unfortunate.  If I understand correctly, we're waiting 2 seconds
to make sure the test doesn't fail.  That won't be flaky if it passes, but it
adds to test latency and would be flaky if it started failing due to a
regression.

I'm also hesitant to add a notification, but it's worth noting that web
developers are going to see the same thing.  If they're not sure if their
background page exists (or if it has gotten stuck), won't they be in the same
boat?  (Sending a request, and then nothing happens.)

+              // it might take a while for the additional background contents
+              // to be recreated.
+              setTimeout(chrome.test.notifyPass, 2000);
+            });
+      });
 }