Issue 10012048: fix for NPE if invalid resource

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10012048: fix for NPE if invalid resource (Closed)

Created:
8 years, 8 months ago by keertip

Modified:
8 years, 8 months ago

Reviewers:
devoncarew

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

fix for NPE if invalid resource Committed: https://code.google.com/p/dart/source/detail?r=6292

Patch Set 1 #

Total comments: 2

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/configs/DartServerLaunchConfigurationDelegate.java	View		2 chunks	+4 lines, -1 line	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

devoncarew

8 years, 8 months ago (2012-04-06 18:47:26 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/10012048/diff/1/editor/tools/plugins/c...
File
editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/configs/DartServerLaunchConfigurationDelegate.java
(right):

https://chromiumcodereview.appspot.com/10012048/diff/1/editor/tools/plugins/c...
editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/configs/DartServerLaunchConfigurationDelegate.java:175:
}
up to an else clause here?

https://chromiumcodereview.appspot.com/10012048/diff/1/editor/tools/plugins/c...
editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/configs/DartServerLaunchConfigurationDelegate.java:185:
return null;
Can you move this return

Expand Messages | Collapse Messages