Normalize droameo benchmarks to legal filenames in perf runner script

tools/testing/perf_testing/run_perf_tests.py

 #!/usr/bin/python
 
 # Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 import datetime
 import getpass
 import math
 try:
@@ skipping 568 matching lines @@
         'getElementsByName',
         'getElementsByName (not in document)']),
     'traverse': ('traverse', [
         'firstChild',
         'lastChild',
         'nextSibling',
         'previousSibling',
         'childNodes'])
 }
 
+# Use legal appengine filenames for benchmark names.
+def legalize_filename(str):
+  remap = {
+      ' ': '_',
+      '(': '_',
+      ')': '_',
+      '*': 'ALL',
+      '=': 'ASSIGN',
+      }
+  for (old, new) in remap.iteritems():
+    str = str.replace(old, new)
+  return str
+
 # TODO(vsm): This is a hack to skip breaking tests.  Triage this
 # failure properly.  The modify suite fails on 32-bit chrome on
 # the mac.
 def get_valid_dromaeo_tags():
   tags = [tag for (tag, _) in DROMAEO_BENCHMARKS.values()]
   if platform.system() == 'Darwin':
     tags.remove('modify')
   return tags
 
 def get_dromaeo_benchmarks():
   valid = get_valid_dromaeo_tags()
   benchmarks = reduce(lambda l1,l2: l1+l2,
                       [tests for (tag, tests) in
                        DROMAEO_BENCHMARKS.values() if tag in valid])
-  return map(lambda str: str.replace(' ', '_'), benchmarks)
+  return map(legalize_filename, benchmarks)
 
 def get_dromaeo_versions():
   return ['js', 'frog_dom', 'frog_html']
 
 def get_dromaeo_url_query(version):
   version = version.replace('_','&')
   tags = get_valid_dromaeo_tags()
   return '|'.join([ '%s&%s' % (version, tag) for tag in tags])
 
 class DromaeoTest(PerformanceTest):
@@ skipping 51 matching lines @@
         revision_num = int(rev.group(1))
         continue
 
       suite_results = re.findall(suite_pattern, line)
       if suite_results:
         for suite_result in suite_results:
           results = re.findall(r'<li>(.*?)</li>', suite_result)
           if results:
             for result in results:
               r = re.match(result_pattern, result)
-              name = r.group(1).strip(':').replace(' ', '_')
+              name = legalize_filename(r.group(1).strip(':'))
               score = float(r.group(2))
               bench_dict[name] += [float(score)]
               self.revision_dict[browser][version][name] += [revision_num]
 
     f.close()
     self.calculate_geometric_mean(browser, version, revision_num)
-  
+
 
 class DromaeoSizeTest(TestRunner):
   """Run tests to determine the compiled file output size of Dromaeo."""
   def __init__(self):
     super(DromaeoSizeTest, self).__init__(
         DROMAEO_SIZE,
         ['browser'], ['dart', 'frog_dom', 'frog_html', 'frog_htmlidiomatic'],
         DROMAEO_BENCHMARKS.keys())
 
   def run_tests(self):
@@ skipping 274 matching lines @@
     while True:
       if has_new_code():
         run_test_sequence(suites, no_build, graph_only, upload)
       else:
         time.sleep(SLEEP_TIME)
   else:
     run_test_sequence(suites, no_build, graph_only, upload)
 
 if __name__ == '__main__':
   main()