Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: WebKit/chromium/src/StorageEventDispatcherImpl.cpp

Issue 10012034: WebKit/WebCore DomStorage House cleaning (Closed) Base URL: http://svn.webkit.org/repository/webkit/trunk/Source/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « WebKit/chromium/src/StorageEventDispatcherChromium.cpp ('k') | WebKit/chromium/src/StorageNamespaceProxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: WebKit/chromium/src/StorageEventDispatcherImpl.cpp
===================================================================
--- WebKit/chromium/src/StorageEventDispatcherImpl.cpp (revision 113961)
+++ WebKit/chromium/src/StorageEventDispatcherImpl.cpp (working copy)
@@ -49,6 +49,7 @@
ASSERT(m_pageGroup);
}
+// FIXME(michaeln): add a sourceStorageArea parameter to this
void StorageEventDispatcherImpl::dispatchStorageEvent(const String& key, const String& oldValue,
const String& newValue, SecurityOrigin* securityOrigin,
const KURL& url, StorageType storageType)
@@ -65,6 +66,8 @@
HashSet<Page*>::const_iterator end = pages.end();
for (HashSet<Page*>::const_iterator it = pages.begin(); it != end; ++it) {
for (Frame* frame = (*it)->mainFrame(); frame; frame = frame->tree()->traverseNext()) {
+ // FIXME(michaeln): identify the srcFrame while in this loop too,
+ // and exclude it from 'frames'.
if (frame->document()->securityOrigin()->equal(securityOrigin))
frames.append(frame);
}
« no previous file with comments | « WebKit/chromium/src/StorageEventDispatcherChromium.cpp ('k') | WebKit/chromium/src/StorageNamespaceProxy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698