Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: WebKit/chromium/src/StorageAreaProxy.cpp

Issue 10012034: WebKit/WebCore DomStorage House cleaning (Closed) Base URL: http://svn.webkit.org/repository/webkit/trunk/Source/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: WebKit/chromium/src/StorageAreaProxy.cpp
===================================================================
--- WebKit/chromium/src/StorageAreaProxy.cpp (revision 113961)
+++ WebKit/chromium/src/StorageAreaProxy.cpp (working copy)
@@ -35,7 +35,6 @@
#include "Page.h"
#include "PageGroup.h"
#include "SecurityOrigin.h"
-#include "StorageAreaImpl.h"
#include "StorageEvent.h"
#include "WebFrameImpl.h"
@@ -140,6 +139,8 @@
}
for (unsigned i = 0; i < frames.size(); ++i) {
+ // FIXME: maybe only raise if the window has an onstorage listener
+ // attached to avoid creating the Storage instance.
ExceptionCode ec = 0;
Storage* storage = frames[i]->domWindow()->sessionStorage(ec);
if (!ec)
@@ -157,6 +158,8 @@
}
for (unsigned i = 0; i < frames.size(); ++i) {
+ // FIXME: maybe only raise if the window has an onstorage listener
+ // attached to avoid creating the Storage instance.
ExceptionCode ec = 0;
Storage* storage = frames[i]->domWindow()->localStorage(ec);
if (!ec)
« no previous file with comments | « WebKit/chromium/public/platform/WebKitPlatformSupport.h ('k') | WebKit/chromium/src/StorageEventDispatcherChromium.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698