Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 10012010: Force deletion of test_shell's RequestProxy on the IO thread. (Closed)

Created:
8 years, 8 months ago by Ami GONE FROM CHROMIUM
Modified:
8 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

Force deletion of test_shell's RequestProxy on the IO thread. This is required by r129062. BUG=122182 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=131170

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use traits instead of PTAR. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -5 lines) Patch
M webkit/tools/test_shell/simple_resource_loader_bridge.cc View 1 3 chunks +20 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Ami GONE FROM CHROMIUM
Tony: I'm not particularly proud of this change; ISTM there should be a better way ...
8 years, 8 months ago (2012-04-05 18:13:05 UTC) #1
tony
On 2012/04/05 18:13:05, Ami Fischman wrote: > Tony: I'm not particularly proud of this change; ...
8 years, 8 months ago (2012-04-05 18:19:12 UTC) #2
darin (slow to review)
https://chromiumcodereview.appspot.com/10012010/diff/1/webkit/tools/test_shell/simple_resource_loader_bridge.cc File webkit/tools/test_shell/simple_resource_loader_bridge.cc (right): https://chromiumcodereview.appspot.com/10012010/diff/1/webkit/tools/test_shell/simple_resource_loader_bridge.cc#newcode276 webkit/tools/test_shell/simple_resource_loader_bridge.cc:276: public base::RefCountedThreadSafe<RequestProxy> { wouldn't it be simpler to just ...
8 years, 8 months ago (2012-04-05 20:45:21 UTC) #3
Ami GONE FROM CHROMIUM
https://chromiumcodereview.appspot.com/10012010/diff/1/webkit/tools/test_shell/simple_resource_loader_bridge.cc File webkit/tools/test_shell/simple_resource_loader_bridge.cc (right): https://chromiumcodereview.appspot.com/10012010/diff/1/webkit/tools/test_shell/simple_resource_loader_bridge.cc#newcode276 webkit/tools/test_shell/simple_resource_loader_bridge.cc:276: public base::RefCountedThreadSafe<RequestProxy> { On 2012/04/05 20:45:21, darin wrote: > ...
8 years, 8 months ago (2012-04-05 22:14:31 UTC) #4
darin (slow to review)
LGTM
8 years, 8 months ago (2012-04-06 17:47:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/10012010/2003
8 years, 8 months ago (2012-04-06 17:55:48 UTC) #6
commit-bot: I haz the power
8 years, 8 months ago (2012-04-06 19:49:07 UTC) #7
Change committed as 131170

Powered by Google App Engine
This is Rietveld 408576698