Issue 10012006: Remove unused code and exclude unused files on Chrome OS too.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10012006: Remove unused code and exclude unused files on Chrome OS too. (Closed)

Created:
8 years, 8 months ago by Craig

Modified:
8 years, 8 months ago

Reviewers:
oshima, willchan no longer on Chromium, zelidrag1

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, oshima

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove unused code and exclude unused files on Chrome OS too. The code used to be part of Chrome OS bug 8285 but these days Chrome OS relies on CrosNetworkChangeNotifierFactory rather than NetworkChangeNotifierLinux. BUG=chromium-os:8285 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=131114

Patch Set 1 #

Patch Set 2 : exclude header on cros #

Patch Set 3 : remove unittest too #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -13 lines)			Patch
M	net/base/network_change_notifier.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	net/base/network_change_notifier_linux.cc	View		1 chunk	+0 lines, -12 lines	0 comments	Download
M	net/net.gyp	View	1 2	2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/craig.schlenter@chromium.org/10012006/5001

8 years, 8 months ago (2012-04-05 17:29:26 UTC) #3

oshima

+zel who did network_change_notifier_chromeos. lgtm though.

8 years, 8 months ago (2012-04-05 17:41:33 UTC) #4

commit-bot: I haz the power

8 years, 8 months ago (2012-04-05 21:06:27 UTC) #5

List of reviewers changed. zelidrag@google.com did a drive-by without LGTM'ing!

Expand Messages | Collapse Messages