Issue 10010046: Return LOOKUP variable instead of CONTEXT for non-context allocated outer scope parameters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10010046: Return LOOKUP variable instead of CONTEXT for non-context allocated outer scope parameters. (Closed)

Created:
8 years, 8 months ago by Vyacheslav Egorov (Chromium)

Modified:
8 years, 8 months ago

Reviewers:
Kevin Millikin (Chromium), Kevin Millikin (Google)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Return LOOKUP variable instead of CONTEXT for non-context allocated outer scope parameters. R=kmillikin@chromium.org BUG=chromium:119609 TEST=test/mjsunit/regress/regress-119609.js Committed: https://code.google.com/p/v8/source/detail?r=11298

Patch Set 1 #

Patch Set 2 : fix, add regression test #

Total comments: 2

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+79 lines, -3 lines)			Patch
	M	src/scopes.cc	View	1	3 chunks	+8 lines, -3 lines	2 comments	Download
	A	test/mjsunit/regress/regress-119609.js	View	1	1 chunk	+71 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Google)

8 years, 8 months ago (2012-04-12 15:43:15 UTC) #2

LGTM.

https://chromiumcodereview.appspot.com/10010046/diff/2001/src/scopes.cc
File src/scopes.cc (right):

https://chromiumcodereview.appspot.com/10010046/diff/2001/src/scopes.cc#newco...
src/scopes.cc:955: // We found a variable variable binding that might be
shadowed
Only one "variable".

https://chromiumcodereview.appspot.com/10010046/diff/2001/src/scopes.cc#newco...
src/scopes.cc:959: } else if (var->is_dynamic()) {
This is kind of subtle and doesn't jive with the comment above that we found a
binding.

Maybe we need some explanation: "we didn't find binding but we found a scope
where we gave up looking for a binding, so we have to give up here, too"?

Expand Messages | Collapse Messages