Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: chrome/browser/extensions/webstore_inline_installer.cc

Issue 10010038: Do not show the install prompt for themes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/webstore_inline_installer.cc
diff --git a/chrome/browser/extensions/webstore_inline_installer.cc b/chrome/browser/extensions/webstore_inline_installer.cc
index a11a194d0b8deb99cbd410416a9fa484ccac59da..eb76482f7601f286c78ba00625f610055957a9a5 100644
--- a/chrome/browser/extensions/webstore_inline_installer.cc
+++ b/chrome/browser/extensions/webstore_inline_installer.cc
@@ -373,20 +373,17 @@ void WebstoreInlineInstaller::OnWebstoreParseSuccess(
prompt.SetInlineInstallWebstoreData(localized_user_count_,
average_rating_,
rating_count_);
-
- if (!ShowExtensionInstallDialogForManifest(profile,
- this,
- manifest,
- id_,
- localized_name_,
- localized_description_,
- &icon_,
- prompt,
- &dummy_extension_)) {
- CompleteInstall(kInvalidManifestError);
+ std::string error;
+ dummy_extension_ = ExtensionInstallUI::GetLocalizedExtensionForDisplay(
+ manifest, id_, localized_name_, localized_description_, &error);
+ if (!dummy_extension_) {
+ OnWebstoreParseFailure(id_, WebstoreInstallHelper::Delegate::MANIFEST_ERROR,
+ kInvalidManifestError);
return;
}
+ install_ui_.reset(new ExtensionInstallUI(profile));
+ install_ui_->ConfirmInlineInstall(this, dummy_extension_, &icon_, prompt);
// Control flow finishes up in InstallUIProceed or InstallUIAbort.
}

Powered by Google App Engine
This is Rietveld 408576698