Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: runtime/vm/code_patcher_x64.cc

Issue 10010029: When checking against non-parametrized types use a cache to hold result tuples (class, result). Tha… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/code_patcher_x64.cc
===================================================================
--- runtime/vm/code_patcher_x64.cc (revision 6245)
+++ runtime/vm/code_patcher_x64.cc (working copy)
@@ -241,6 +241,24 @@
return DartCallPattern::kCallPatternSize;
}
+
+RawArray* CodePatcher::GetTypeTestArray(uword instruction_address) {
+ UNIMPLEMENTED(); // Untested.
+ Array& result = Array::Handle();
+ uint64_t* target_addr = reinterpret_cast<uint64_t*>(instruction_address + 1);
regis 2012/04/06 00:44:01 I do not think offset +1 is correct. You always to
srdjan 2012/04/06 15:58:34 Deleting the code in both, leaving UNIMPLEMENTED.
+ result ^= reinterpret_cast<RawObject*>(*target_addr);
+ return result.raw();
+}
+
+
+void CodePatcher::SetTypeTestArray(uword instruction_address,
+ const Array& value) {
+ UNIMPLEMENTED(); // Untested.
+ uint64_t* target_addr = reinterpret_cast<uint64_t*>(instruction_address + 1);
regis 2012/04/06 00:44:01 ditto
srdjan 2012/04/06 15:58:34 ditto
+ *target_addr = reinterpret_cast<uint64_t>(value.raw());
+}
+
+
} // namespace dart
#endif // defined TARGET_ARCH_X64

Powered by Google App Engine
This is Rietveld 408576698