Error on multiple files with same basenames in target.

Error on multiple files with same basenames in static library targets.
Committed: https://code.google.com/p/gyp/source/detail?r=1354

[Nico, 2012-04-05 22:43:45]

The motivation is to make gyp more uniform across build systems. Static
libraries where several files have the same basename are build time errors in
msvc, and libtool warns about them.

[scottmg, 2012-04-05 23:12:49]

On 2012/04/05 22:43:45, Nico wrote:
> The motivation is to make gyp more uniform across build systems. Static
> libraries where several files have the same basename are build time errors in
> msvc, and libtool warns about them.

I think this is a sort-of bug in msvs.py. (Pretty sure IDE-created projects will
rename the duplicate .obj files to avoid the problem).

I agree with disallowing it for consistency though, probably just disallow it in
all target types rather than only static_library?

https://chromiumcodereview.appspot.com/10010028/diff/5/pylib/gyp/input.py
File pylib/gyp/input.py (right):

https://chromiumcodereview.appspot.com/10010028/diff/5/pylib/gyp/input.py#new...
pylib/gyp/input.py:2116: is_compiled_file = ext in ['.c', '.cc', '.m', '.mm',
'.s', '.S']
+= .cpp? (or is there a canonical list like this somewhere?)

[Nico, 2012-04-05 23:23:21]

On 2012/04/05 23:12:49, scottmg wrote:
> On 2012/04/05 22:43:45, Nico wrote:
> > The motivation is to make gyp more uniform across build systems. Static
> > libraries where several files have the same basename are build time errors
in
> > msvc, and libtool warns about them.
> 
> I think this is a sort-of bug in msvs.py. (Pretty sure IDE-created projects
will
> rename the duplicate .obj files to avoid the problem).

Do you know in which way? If this is fixable in msvs.py, that's better.

> I agree with disallowing it for consistency though, probably just disallow it
in
> all target types rather than only static_library?

ffmpeg (a loadable_module) has some violations:

pcm: libavcodec/pcm.c libavformat/pcm.c
audioconvert: libavcodec/audioconvert.c libavutil/audioconvert.c
options: libavcodec/options.c libavformat/options.c
utils: libavcodec/utils.c libavformat/utils.c libavutil/utils.c
cpu: libavutil/x86/cpu.c libavutil/cpu.c

> 
> https://chromiumcodereview.appspot.com/10010028/diff/5/pylib/gyp/input.py
> File pylib/gyp/input.py (right):
> 
>
https://chromiumcodereview.appspot.com/10010028/diff/5/pylib/gyp/input.py#new...
> pylib/gyp/input.py:2116: is_compiled_file = ext in ['.c', '.cc', '.m', '.mm',
> '.s', '.S']
> += .cpp? (or is there a canonical list like this somewhere?)

Done, cxx as well. make.py and ninja.py have extension lists. I haven't anything
in non-generator code.

[Mark Mentovai, 2012-04-06 21:28:42]

LGTM