Chromium Code Reviews| Index: chrome/browser/resources/about_stats.js |
| diff --git a/chrome/browser/resources/about_stats.js b/chrome/browser/resources/about_stats.js |
| index 30b8b96d675df547c9294d9f72a93d010ff1bfdc..3c88c90bf8dce62cc770ea4689b989e607fb35fe 100644 |
| --- a/chrome/browser/resources/about_stats.js |
| +++ b/chrome/browser/resources/about_stats.js |
| @@ -1,4 +1,4 @@ |
| -// Copyright (c) 2011 The Chromium Authors. All rights reserved. |
| +// Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| // Use of this source code is governed by a BSD-style license that can be |
| // found in the LICENSE file. |
| @@ -43,61 +43,61 @@ function filterMatching(text, nodelist, functionToGetNameNode) { |
| for (var i = 0, node; node = nodelist[i]; i++) { |
| var name = functionToGetNameNode(node).innerHTML.toLowerCase(); |
| if (showAll || name.indexOf(text) >= 0) { |
|
Dan Beam
2012/04/05 22:24:13
nit: no curlies
Tyler Breisacher (Chromium)
2012/04/05 22:39:13
Done.
|
| - node.style.display = "table-row"; |
| + node.style.display = 'table-row'; |
| } else { |
| - node.style.display = "none"; |
| + node.style.display = 'none'; |
| } |
| } |
| } |
| /* Hides or shows counters based on the user's current filter selection. */ |
| function doFilter() { |
| - var filter = document.getElementById("filter"); |
| + var filter = document.getElementById('filter'); |
| var text = filter.value.toLowerCase(); |
| - var nodes = document.getElementsByName("counter"); |
| + var nodes = document.getElementsByName('counter'); |
| filterMatching(text, nodes, getCounterNameFromCounterNode); |
| - var nodes = document.getElementsByName("timer"); |
| + var nodes = document.getElementsByName('timer'); |
| filterMatching(text, nodes, getTimerNameFromTimerNode); |
| } |
| /* Colors the counters based on increasing or decreasing value. */ |
| function doColor() { |
| - var nodes = document.getElementsByName("counter"); |
| + var nodes = document.getElementsByName('counter'); |
| for (var i = 0, node; node = nodes[i]; i++) { |
| var child = getCounterDeltaFromCounterNode(node); |
| var delta = child.innerHTML; |
| if (delta > 0) { |
|
Dan Beam
2012/04/05 22:24:13
nor here
Tyler Breisacher (Chromium)
2012/04/05 22:39:13
Done.
|
| - child.style.color = "Green"; |
| + child.style.color = 'Green'; |
| } else if (delta == 0) { |
| - child.style.color = "Black"; |
| + child.style.color = 'Black'; |
| } else { |
| - child.style.color = "Red"; |
| + child.style.color = 'Red'; |
| } |
| } |
| } |
| /* Counters with no values are null. Remove them. */ |
| function removeNullValues() { |
| - var nodes = document.getElementsByName("counter"); |
| + var nodes = document.getElementsByName('counter'); |
| for (var i = nodes.length - 1; i >= 0; i--) { |
| var node = nodes[i]; |
| var value = getCounterValueFromCounterNode(node).innerHTML; |
| - if (value == "null") { |
| + if (value == 'null') { |
|
Dan Beam
2012/04/05 22:24:13
:^( == 'null', nor here
Tyler Breisacher (Chromium)
2012/04/05 22:39:13
Done.
|
| node.parentNode.removeChild(node); |
| } |
| } |
| - var nodes = document.getElementsByName("timer"); |
| + var nodes = document.getElementsByName('timer'); |
| for (var i = 0, node; node = nodes[i]; i++) { |
| var value_node = getTimerValueFromTimerNode(node); |
| - if (value_node.innerHTML == "null") { |
| - value_node.innerHTML = ""; |
| + if (value_node.innerHTML == 'null') { |
|
Dan Beam
2012/04/05 22:24:13
:_( == 'null', nor here
Tyler Breisacher (Chromium)
2012/04/05 22:39:13
Done.
|
| + value_node.innerHTML = ''; |
| } |
| } |
| } |
| /* Compute the average time for timers */ |
| function computeTimes() { |
| - var nodes = document.getElementsByName("timer"); |
| + var nodes = document.getElementsByName('timer'); |
| for (var i = 0, node; node = nodes[i]; i++) { |
| var count = getTimerValueFromTimerNode(node).innerHTML; |
| if (count.length > 0) { |
| @@ -116,18 +116,18 @@ function onLoadWork() { |
| jstProcess(input, output); |
| // Add handlers to dynamically created HTML elements. |
| - var elements = document.getElementsByName("string-sort"); |
| + var elements = document.getElementsByName('string-sort'); |
| for (var i = 0; i < elements.length; ++i) |
| - elements[i].onclick = function () { sort_table("string"); }; |
| + elements[i].onclick = function() { sort_table('string'); }; |
| - elements = document.getElementsByName("number-sort"); |
| + elements = document.getElementsByName('number-sort'); |
| for (i = 0; i < elements.length; ++i) |
| - elements[i].onclick = function () { sort_table("number"); }; |
| + elements[i].onclick = function() { sort_table('number'); }; |
| doColor(); |
| removeNullValues(); |
| computeTimes(); |
| - document.getElementById("filter").focus(); |
| + document.getElementById('filter').focus(); |
| } |
| // The function should only be used as the event handler |
| @@ -137,7 +137,7 @@ function onLoadWork() { |
| // The function sorts rows after the row with onclick event handler. |
| // |
| // type: the data type, 'string', 'number' |
| -function sort_table(type){ |
| +function sort_table(type) { |
| var cell = event.target; |
| var cnum = cell.cellIndex; |
| @@ -155,14 +155,14 @@ function sort_table(type){ |
| rows.push(table.rows[i]); |
| // a, b are strings |
| - function compare_strings(a,b) { |
| + function compare_strings(a, b) { |
| if (a == b) return 0; |
| if (a < b) return -1; |
| return 1; |
| } |
| // a, b are numbers |
| - function compare_numbers(a,b) { |
| + function compare_numbers(a, b) { |
| var x = isNaN(a) ? 0 : a; |
| var y = isNaN(b) ? 0 : b; |
| return x - y; |
| @@ -174,7 +174,7 @@ function sort_table(type){ |
| var x = a.cells[cnum].innerText; |
| var y = b.cells[cnum].innerText; |
| return compare_strings(x, y); |
| - } ; |
| + }; |
| } else if (type === 'number') { |
| sort_func = function(a, b) { |