JS style nits

chrome/browser/resources/sync_setup_overlay.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
-  const OptionsPage = options.OptionsPage;
+  /** @const */ var OptionsPage = options.OptionsPage;
 
   // Variable to track if a captcha challenge was issued. If this gets set to
   // true, it stays that way until we are told about successful login from
   // the browser.  This means subsequent errors (like invalid password) are
   // rendered in the captcha state, which is basically identical except we
   // don't show the top error blurb 'Error Signing in' or the 'Create
   // account' link.
   var captchaChallengeActive_ = false;
 
   // True if the synced account uses a custom passphrase.
@@ skipping 50 matching lines @@
     showOverlay_: function() {
       OptionsPage.navigateToPage('syncSetup');
     },
 
     closeOverlay_: function() {
       OptionsPage.closeOverlay();
     },
 
     /** @inheritDoc */
     didShowPage: function() {
-      var forceLogin = document.location.hash == "#forceLogin";
+      var forceLogin = document.location.hash == '#forceLogin';
       var result = JSON.stringify({'forceLogin': forceLogin});
       chrome.send('SyncSetupAttachHandler', [result]);
     },
 
     /** @inheritDoc */
     didClosePage: function() {
       chrome.send('SyncSetupDidClosePage');
     },
 

[Dan Beam, 2012/04/05 22:24:13]

none of these are doc'd?!

     getEncryptionRadioCheckedValue_: function() {
       var f = $('choose-data-types-form');
       for (var i = 0; i < f.encrypt.length; ++i) {
         if (f.encrypt[i].checked)
           return f.encrypt[i].value;
       }
 
       return undefined;

[Dan Beam, 2012/04/05 22:24:13]

wat?!

     },
 
     getPassphraseRadioCheckedValue_: function() {
       var f = $('choose-data-types-form');
       for (var i = 0; i < f.option.length; ++i) {
         if (f.option[i].checked) {
           return f.option[i].value;
         }
       }
 
       return undefined;

[Dan Beam, 2012/04/05 22:24:13]

ugh

     },
 
     disableEncryptionRadioGroup_: function() {
       var f = $('choose-data-types-form');
       for (var i = 0; i < f.encrypt.length; ++i)
         f.encrypt[i].disabled = true;
     },
 
     onPassphraseRadioChanged_: function() {
       var visible = this.getPassphraseRadioCheckedValue_() == 'explicit';
@@ skipping 96 matching lines @@
         usePassphrase = false;
       }
 
       // Don't allow the user to tweak the settings once we send the
       // configuration to the backend.
       this.setInputElementsDisabledState_(true);
       this.animateDisableLink_($('use-default-link'), true, null);
 
       // These values need to be kept in sync with where they are read in
       // SyncSetupFlow::GetDataTypeChoiceData().
       var result = JSON.stringify({

[Dan Beam, 2012/04/05 22:24:13]

this is needlessly encoded to JSON twice?! </vent>

         'syncAllDataTypes': syncAll,
         'sync_bookmarks': syncAll || $('bookmarks-checkbox').checked,
         'sync_preferences': syncAll || $('preferences-checkbox').checked,
         'sync_themes': syncAll || $('themes-checkbox').checked,
         'sync_passwords': syncAll || $('passwords-checkbox').checked,
         'sync_autofill': syncAll || $('autofill-checkbox').checked,
         'sync_extensions': syncAll || $('extensions-checkbox').checked,
         'sync_typed_urls': syncAll || $('typed-urls-checkbox').checked,
         'sync_apps': syncAll || $('apps-checkbox').checked,
         'sync_sessions': syncAll || $('sessions-checkbox').checked,
@@ skipping 94 matching lines @@
         $('sessions-checkbox').checked = args.sync_sessions;
         $('sessions-item').hidden = false;
       } else {
         $('sessions-item').hidden = true;
       }
 
       this.setCheckboxesToKeepEverythingSynced_(args.syncAllDataTypes);
     },
 
     setEncryptionRadios_: function(args) {
       if (args['encryptAllData']) {

[Dan Beam, 2012/04/05 22:24:13]

better to use . instead of [], :(

         $('encrypt-all-option').checked = true;
         this.disableEncryptionRadioGroup_();
       } else {
         $('encrypt-sensitive-option').checked = true;
       }
     },
 
     setPassphraseRadios_: function(args) {
       if (args['usePassphrase']) {
         $('explicit-option').checked = true;
@@ skipping 108 matching lines @@
       // Warn the user about their incorrect passphrase if we need a passphrase
       // and the passphrase field is non-empty (meaning they tried to set it
       // previously but failed).
       $('incorrect-passphrase').hidden =
           !(args['usePassphrase'] && args['passphrase_failed']);
 
       $('sync-passphrase-warning').hidden = false;
       $('passphrase').focus();
     },
 
     /** @private */

[Dan Beam, 2012/04/05 22:24:13]

not enough doc!

     showCustomizePage_: function(args, syncEverything) {
       $('confirm-sync-preferences').hidden = true;
       $('customize-sync-preferences').hidden = false;
 
       $('sync-custom-passphrase-container').hidden = false;
       $('sync-existing-passphrase-container').hidden = true;
 
       // If the user has selected the 'Customize' page on initial set up, it's
       // likely he intends to change the data types. Select the
       // 'Choose data types' option in this case.
@@ skipping 401 matching lines @@
   };
 
   SyncSetupOverlay.showStopSyncingUI = function() {
     SyncSetupOverlay.getInstance().showStopSyncingUI_();
   };
 
   // Export
   return {
     SyncSetupOverlay: SyncSetupOverlay
   };
 });

[Dan Beam, 2012/04/05 22:24:13]

tl;dr too much pain