JS style nits

chrome/browser/resources/sessions.js

-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 

[Dan Beam, 2012/04/05 22:24:13]

should probably be a

  cr.define('session', function() {

up here or something

 localStrings = new LocalStrings();

[Dan Beam, 2012/04/05 22:24:13]

seems like these are all global assignments, :\

 
 // UTF8 sequence for an arrow triangle pointing down.
-kExpandedArrow = "\u25BE";
+kExpandedArrow = '\u25BE';

[Dan Beam, 2012/04/05 22:24:13]

I don't see a reason to have these like this instead of just ▾ and ▸.

P.S.

▾ ▾ ▾ 
 ▾ ▾    amidoinitrite? 
  ▾ 

[Tyler Breisacher (Chromium), 2012/04/05 22:39:13]

I would guess it's because someday, someone will open this with a text editor
that doesn't understand Unicode very well, and it will get totally messed up.

 // UTF8 sequence for an arrow triangle pointing right.
-kCollapsedArrow = "\u25B8";
+kCollapsedArrow = '\u25B8';
 
 /**
  * Requests the list of sessions from the backend.
  */
 function requestSessions() {
-  chrome.send('requestSessionList', [])
+  chrome.send('requestSessionList');
 }
 
 /**
  * Expands or collapses the specified list.
  */
 function toggleExpandedState(div) {
   if (div.textContent.indexOf(kExpandedArrow) != -1) {
     div.textContent = div.textContent.replace(kExpandedArrow, kCollapsedArrow);
-    div.parentNode.querySelector(".indent").hidden = true;
+    div.parentNode.querySelector('.indent').hidden = true;
   } else {
     div.textContent = div.textContent.replace(kCollapsedArrow, kExpandedArrow);
-    div.parentNode.querySelector(".indent").hidden = false;
+    div.parentNode.querySelector('.indent').hidden = false;
   }
 }
 
 /**
  * Creates a div element to serve as an expandable/collapsable
  * title for a list of windows or tabs.

[Dan Beam, 2012/04/05 22:24:13]

no @returns

  */
 function createTitleDiv(className, textContent) {
   var div = document.createElement('div');
   div.className = className + ' expandable';
   div.textContent = kExpandedArrow + ' ' + textContent;
   div.onclick = Function('toggleExpandedState(this)');

[Dan Beam, 2012/04/05 22:24:13]

wat!

[Tyler Breisacher (Chromium), 2012/04/05 22:39:13]

Yeah, it should obviously be

  div.onclick = new Function('toggleExpandedState(this);');

=P

But seriously, I'll do another CL with this type of change in it, plus
documentation, and all the other stuff you mentioned in this file..

   return div;
 }
 
 /**
  * Utility function to call |transformFn| on each element of |from|
  * and add them to a div which is then added to |container|.
  */
 function addItems(container, from, transformFn) {
   var divBlock = document.createElement('div');
   divBlock.className = 'indent';
   for (var i = 0; i < from.length; i++) {
     divBlock.appendChild(transformFn(from[i]));
   }
   container.appendChild(divBlock);
 }
 
 /**
  * Transforms a tab into an HTML element.

[Dan Beam, 2012/04/05 22:24:13]

no @returns

  */
 function transformTab(tab) {
   var tabItem = document.createElement('a');
   tabItem.setAttribute('href', tab.url);
   tabItem.textContent = tab.title;
   tabItem.className = 'tab-link';
   tabItem.style.backgroundImage = url('chrome://favicon/' + tab.url);

[Dan Beam, 2012/04/05 22:24:13]

was really confused until I figured out url() is a function in util.js

   return tabItem;
 }
 
 /**
  * Transforms a window into an HTML element.

[Dan Beam, 2012/04/05 22:24:13]

no @returns

  */
 function transformWindow(window) {
   var windowDiv = document.createElement('div');
-  windowDiv.className = "window";
+  windowDiv.className = 'window';
   windowDiv.appendChild(createTitleDiv('window-title', 'Window'));
   addItems(windowDiv, window.tabs, transformTab);
   return windowDiv;
 }
 
 /**
  * Transforms a session into an HTML element.

[Dan Beam, 2012/04/05 22:24:13]

no @returns

  */
 function transformSession(session) {
   var sessionDiv = document.createElement('div');
   var sessionName = session.name.length == 0 ? 'Session' : session.name;
-  sessionDiv.className = "session";
+  sessionDiv.className = 'session';
   sessionDiv.appendChild(createTitleDiv('session-title', sessionName));
   addItems(sessionDiv, session.windows, transformWindow);
   return sessionDiv;
 }
 
 /**
  * Creates the UI for the sessions tree.
  */
 function createSessionTreeUI(sessionList) {
   $('sessions-summary-text').textContent =
@@ skipping 34 matching lines @@
  * Callback from backend with the list of sessions. Builds the UI.
  * @param {array} sessionList The list of sessions.
  * @param {array} magicList List of "interesting" tabs.
  */
 function updateSessionList(sessionList, magicList) {
   createSessionTreeUI(sessionList);
   createMagicListUI(magicList);
 }
 
 document.addEventListener('DOMContentLoaded', requestSessions);