JS style nits

chrome/browser/resources/policy.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * This variable structure is here to document the structure that the template
  * expects to correctly populate the page.
  */
 var policyDataFormat = {
   // Whether any of the policies in 'policies' have a value.
   'anyPoliciesSet': true,

[Dan Beam, 2012/04/05 22:24:13]

'damnIt'

 
   // False if the policy information is being sent due to an initial page load
   // and true if it is being sent due to a change of policy values.
   'isPolicyUpdate': false,
   'policies': [
     {
       'level': 'managed',
       'name': 'AllowXYZ',
       'set': true,
       'scope': 'Machine',
@@ skipping 18 matching lines @@
   }
 };
 
 cr.define('policies', function() {
 
   function Policy() {
   }
 
   cr.addSingletonGetter(Policy);
 
   Policy.prototype = {

[Dan Beam, 2012/04/05 22:24:13]

nit: I don't think we usually have an \n here

[Tyler Breisacher (Chromium), 2012/04/05 22:49:55]

Done.

 
     /**
      * True if none of the received policies are actually set, false otherwise.
      * @type {boolean}
      */
     noActivePolicies_: false,
 
     /**
      * The current search term for filtering of the policy table.
      * @type {string}
      * @private
      */
     searchTerm_: '',
 
     /**
      * Takes the |policyData| argument and populates the page with this data. It
      * expects an object structure like the policyDataFormat above.
      * @param {Object} policyData Detailed info about policies.
      */
     renderTemplate: function(policyData) {
       this.noActivePolicies_ = !policyData.anyPoliciesSet;
 
       if (this.noActivePolicies_)
         $('no-policies').hidden = false;
       if (policyData.status.displayStatusSection)
-        $('status-section').hidden = false;;
+        $('status-section').hidden = false;
 
       // This is the javascript code that processes the template:
       var input = new JsEvalContext(policyData);
       var output = $('data-template');
       jstProcess(input, output);
 
       var toggles = document.querySelectorAll('.policy-set * .toggler');
       for (var i = 0; i < toggles.length; i++) {
         toggles[i].hidden = true;
         toggles[i].onclick = function() {
           Policy.getInstance().toggleCellExpand_(this);
         };
       }
 
       var containers = document.querySelectorAll('.text-container');
       for (var i = 0; i < containers.length; i++)
-        this.initTextContainer_(containers[i])
+        this.initTextContainer_(containers[i]);
     },
 
     /**
      * Filters the table of policies by name.
      * @param {string} term The search string.
      */
     filterTable: function(term) {
       this.searchTerm_ = term.toLowerCase();
       var table = $('policy-table');
       var showUnsent = $('toggle-unsent-policies').checked;
@@ skipping 145 matching lines @@
    * status data.
    */
   Policy.initialize = function() {
     i18nTemplate.process(document, templateData);
     Policy.requestData();
 
     // Set HTML event handlers.
     $('fetch-policies-button').onclick = function(event) {
       this.disabled = true;
       Policy.triggerPolicyFetch();
     }

[Dan Beam, 2012/04/05 22:24:13]

;

[Tyler Breisacher (Chromium), 2012/04/05 22:49:55]

Done.

 
     $('toggle-unsent-policies').onchange = function(event) {
       Policy.getInstance().updatePolicyVisibility();
     };
 
     $('search-field').onsearch = function(event) {
       Policy.getInstance().filterTable(this.value);
     };
   };
 
   // Export
   return {
     Policy: Policy
   };
 });
 
 var Policy = policies.Policy;
 
 // Get data and have it displayed upon loading.

[Dan Beam, 2012/04/05 22:24:13]

delicious copy pasta is not so delicious

[Tyler Breisacher (Chromium), 2012/04/05 22:49:55]

♨

 document.addEventListener('DOMContentLoaded', policies.Policy.initialize);