JS style nits

chrome/browser/resources/plugins.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * This variable structure is here to document the structure that the template
  * expects to correctly populate the page.
  */
 var pluginDataFormat = {
   'plugins': [

[Dan Beam, 2012/04/05 22:24:13]

'pain'

     {
       'name': 'Group Name',
       'description': 'description',
       'version': 'version',
       'update_url': 'http://update/',
       'critical': true,
       'enabled': true,
       'plugin_files': [
         {
           'path': '/blahblah/blahblah/MyCrappyPlugin.plugin',
           'name': 'MyCrappyPlugin',
           'version': '1.2.3',
           'description': 'My crappy plugin',
           'mimeTypes': [
             { 'description': 'Foo Media',
-              'fileExtensions': [ 'foo' ],
+              'fileExtensions': ['foo'],
               'mimeType': 'application/x-my-foo' },
             { 'description': 'Bar Stuff',
-              'fileExtensions': [ 'bar','baz' ],
+              'fileExtensions': ['bar', 'baz'],
               'mimeType': 'application/my-bar' }
           ],
           'enabledMode': 'enabledByUser'
         },
         {
           'path': '/tmp/MyFirst.plugin',
           'name': 'MyFirstPlugin',
           'version': '3.14r15926',
           'description': 'My first plugin',
           'mimeTypes': [
             { 'description': 'New Guy Media',
-              'fileExtensions': [ 'mfp' ],
+              'fileExtensions': ['mfp'],
               'mimeType': 'application/x-my-first' }
           ],
           'enabledMode': 'enabledByPolicy'
         },
         {
           'path': '/foobar/baz/YourGreatPlugin.plugin',
           'name': 'YourGreatPlugin',
           'version': '4.5',
           'description': 'Your great plugin',
           'mimeTypes': [
             { 'description': 'Baz Stuff',
-              'fileExtensions': [ 'baz' ],
+              'fileExtensions': ['baz'],
               'mimeType': 'application/x-your-baz' }
           ],
           'enabledMode': 'disabledByUser'
         },
         {
           'path': '/foobiz/bar/HisGreatPlugin.plugin',
           'name': 'HisGreatPlugin',
           'version': '1.2',
           'description': 'His great plugin',
           'mimeTypes': [
             { 'description': 'More baz Stuff',
-              'fileExtensions': [ 'bor' ],
+              'fileExtensions': ['bor'],
               'mimeType': 'application/x-his-bor' }
           ],
           'enabledMode': 'disabledByPolicy'
         }
       ]
     }
   ]
 };
 
 /**
  * Takes the |pluginsData| input argument which represents data about the
  * currently installed/running plugins and populates the html jstemplate with
  * that data. It expects an object structure like the above.
  * @param {Object} pluginsData Detailed info about installed plugins
  */
 function renderTemplate(pluginsData) {
   // This is the javascript code that processes the template:
   var input = new JsEvalContext(pluginsData);
   var output = document.getElementById('pluginTemplate');
   jstProcess(input, output);
 }
 
 /**
  * Asks the C++ PluginsDOMHandler to get details about the installed plugins and
  * return detailed data about the configuration. The PluginsDOMHandler should
  * reply to returnPluginsData() (below).
  */
 function requestPluginsData() {
-  chrome.send('requestPluginsData', []);
-  chrome.send('getShowDetails', []);
+  chrome.send('requestPluginsData');
+  chrome.send('getShowDetails');
 }
 
 function loadShowDetailsFromPrefs(show_details) {
   tmiModeExpanded = show_details;
   document.getElementById('collapse').style.display =
       show_details ? 'inline' : 'none';
   document.getElementById('expand').style.display =
       show_details ? 'none' : 'inline';
 
   document.body.className = show_details ? 'show-tmi-mode' : 'hide-tmi-mode';
 }
 
 /**
  * Called by the web_ui_ to re-populate the page with data representing the
  * current state of installed plugins.

[Dan Beam, 2012/04/05 22:24:13]

@param? :(

[Tyler Breisacher (Chromium), 2012/04/05 22:49:55]

This CL is only super mechanical stuff, but yes. I'll do another pass for
documentation and such.

  */
-function returnPluginsData(pluginsData){
+function returnPluginsData(pluginsData) {
   var bodyContainer = document.getElementById('body-container');
   var body = document.body;
 
   // Set all page content to be visible so we can measure heights.
   bodyContainer.style.visibility = 'hidden';
   body.className = '';
   var slidables = document.getElementsByClassName('show-in-tmi-mode');
   for (var i = 0; i < slidables.length; i++)
     slidables[i].style.height = 'auto';
 
   renderTemplate(pluginsData);
 
   // Add handlers to dynamically created HTML elements.
   var links = document.getElementsByClassName('disable-plugin-link');
   for (var i = 0; i < links.length; i++) {
-    links[i].onclick = function () {
+    links[i].onclick = function() {
       handleEnablePlugin(this, false, false);
       return false;

[Dan Beam, 2012/04/05 22:24:13]

damn it, I just realized these are being used instead of preventDefault() :.(

     };
   }
   links = document.getElementsByClassName('enable-plugin-link');
   for (var i = 0; i < links.length; i++) {
-    links[i].onclick = function () {
+    links[i].onclick = function() {
       handleEnablePlugin(this, true, false);
       return false;
     };
   }
   links = document.getElementsByClassName('disable-group-link');
   for (var i = 0; i < links.length; i++) {
-    links[i].onclick = function () {
+    links[i].onclick = function() {
       handleEnablePlugin(this, false, true);
       return false;
     };
   }
   links = document.getElementsByClassName('enable-group-link');
   for (var i = 0; i < links.length; i++) {
-    links[i].onclick = function () {
+    links[i].onclick = function() {
       handleEnablePlugin(this, true, true);
       return false;
     };
   }
   var checkboxes = document.getElementsByClassName('always-allow');
   for (var i = 0; i < checkboxes.length; i++) {
-    checkboxes[i].onclick = function () {
-      handleSetPluginAlwaysAllowed(this)
+    checkboxes[i].onclick = function() {
+      handleSetPluginAlwaysAllowed(this);
     };
-  };
+  }
 
   // Make sure the left column (with "Description:", "Location:", etc.) is the
   // same size for all plugins.
   var labels = document.getElementsByClassName('plugin-details-label');
   var maxLabelWidth = 0;
   for (var i = 0; i < labels.length; i++)
     labels[i].style.width = 'auto';
   for (var i = 0; i < labels.length; i++)
     maxLabelWidth = Math.max(maxLabelWidth, labels[i].offsetWidth);
   for (var i = 0; i < labels.length; i++)
@@ skipping 42 matching lines @@
       tmiModeExpanded ? 'show-tmi-mode' : 'hide-tmi-mode';
 
   chrome.send('saveShowDetailsToPrefs', [String(tmiModeExpanded)]);
 }
 
 function handleSetPluginAlwaysAllowed(el) {
   chrome.send('setPluginAlwaysAllowed', [el.identifier, el.checked]);
 }
 
 /**
  * Determines whether a plugin's version should be displayed.

[Dan Beam, 2012/04/05 22:24:13]

neither of these have @return, :(

  */
 function shouldDisplayPluginVersion(plugin) {
   return !!plugin.version && plugin.version != '0';
 }
 
 /**
  * Determines whether a plugin's description should be displayed.
  */
 function shouldDisplayPluginDescription(plugin) {
   // Only display the description if it's not blank and if it's not just the
   // name, version, or combination thereof.
   return plugin.description &&
          plugin.description != plugin.name &&
          plugin.description != plugin.version &&
          plugin.description != 'Version ' + plugin.version &&
          plugin.description != plugin.name + ' ' + plugin.version;
 }
 
 /**
  * Determines whether a plugin is enabled or not.
  */
 function isPluginEnabled(plugin) {
   return plugin.enabledMode == 'enabledByUser' ||
          plugin.enabledMode == 'enabledByPolicy';
 }
 
 // Unfortunately, we don't have notifications for plugin (list) status changes
 // (yet), so in the meanwhile just update regularly.
 setInterval(requestPluginsData, 30000);

[Dan Beam, 2012/04/05 22:24:13]

ughhhhhhhhh

 
 // Get data and have it displayed upon loading.
 document.addEventListener('DOMContentLoaded', requestPluginsData);
 
 // Add handlers to static HTML elements.
 document.getElementById('collapse').onclick = toggleTmiMode;
 document.getElementById('expand').onclick = toggleTmiMode;
 document.getElementById('details-link').onclick = toggleTmiMode;

[Dan Beam, 2012/04/05 22:24:13]

nit: no \n

[Tyler Breisacher (Chromium), 2012/04/05 22:49:55]

Done.