JS style nits

chrome/browser/resources/flags.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * This variable structure is here to document the structure that the template
  * expects to correctly populate the page.
  */
 var flagsExperimentsDataFormat = {
   'flagsExperiments': [

[Dan Beam, 2012/04/05 22:24:13]

I think we generally don't put '' around the key names.

     {
       'internal_name': 'Experiment ID string',
       'name': 'Experiment Name',
       'description': 'description',
       // enabled is only set if the experiment is single valued.
       'enabled': true,
       // choices is only set if the experiment has multiple values.
       'choices': [
         {
           'internal_name': 'Experiment ID string',
@@ skipping 19 matching lines @@
  */
 function renderTemplate(flagsExperimentsData) {
   // This is the javascript code that processes the template:
   var input = new JsEvalContext(flagsExperimentsData);
   var output = document.getElementById('flagsExperimentTemplate');
   jstProcess(input, output);
 
   // Add handlers to dynamically created HTML elements.
   var elements = document.getElementsByClassName('experiment-select');
   for (var i = 0; i < elements.length; ++i) {
-    elements[i].onchange = function () {
+    elements[i].onchange = function() {

[Dan Beam, 2012/04/05 22:24:13]

STEPHEN! (jk, saw this when I reviewed his patch, didn't matter at the time
[started looking around, urge to kill rose])

       handleSelectChoiceExperiment(this, this.selectedIndex);
       return false;
     };
   }
 
   elements = document.getElementsByClassName('experiment-disable-link');
   for (var i = 0; i < elements.length; ++i) {
-    elements[i].onclick = function () {
+    elements[i].onclick = function() {
       handleEnableExperiment(this, false);
       return false;
     };
   }
 
   elements = document.getElementsByClassName('experiment-enable-link');
   for (var i = 0; i < elements.length; ++i) {
-    elements[i].onclick = function () {
+    elements[i].onclick = function() {
       handleEnableExperiment(this, true);
       return false;
     };
   }
 
   elements = document.getElementsByClassName('experiment-restart-button');
   for (var i = 0; i < elements.length; ++i) {
     elements[i].onclick = restartBrowser;
   }
 }
 
 /**
  * Asks the C++ FlagsDOMHandler to get details about the available experiments
  * and return detailed data about the configuration. The FlagsDOMHandler
  * should reply to returnFlagsExperiments() (below).
  */
 function requestFlagsExperimentsData() {
-  chrome.send('requestFlagsExperiments', []);
+  chrome.send('requestFlagsExperiments');
 }
 
 /**
  * Asks the C++ FlagsDOMHandler to restart the browser (restoring tabs).
  */
 function restartBrowser() {
-  chrome.send('restartBrowser', []);
+  chrome.send('restartBrowser');
 }
 
 /**
  * Called by the WebUI to re-populate the page with data representing the
  * current state of installed experiments.
  */
-function returnFlagsExperiments(flagsExperimentsData){
+function returnFlagsExperiments(flagsExperimentsData) {
   var bodyContainer = document.getElementById('body-container');
   renderTemplate(flagsExperimentsData);
   bodyContainer.style.visibility = 'visible';
 }
 
 /**
  * Handles a 'enable' or 'disable' button getting clicked.
  */
 function handleEnableExperiment(node, enable) {
   // Tell the C++ FlagsDOMHandler to enable/disable the experiment.
   chrome.send('enableFlagsExperiment', [String(node.internal_name),
                                        String(enable)]);

[Dan Beam, 2012/04/05 22:24:13]

+1\s

[Tyler Breisacher (Chromium), 2012/04/05 22:49:55]

Done.

   requestFlagsExperimentsData();
 }
 
 /**
  * Invoked when the selection of a multi-value choice is changed to the
  * specified index.
  */
 function handleSelectChoiceExperiment(node, index) {
   // Tell the C++ FlagsDOMHandler to enable the selected choice.
   chrome.send('enableFlagsExperiment',
-              [String(node.internal_name) + "@" + index, "true"]);
+              [String(node.internal_name) + '@' + index, 'true']);

[Dan Beam, 2012/04/05 22:24:13]

'true' vs. true?!

[Tyler Breisacher (Chromium), 2012/04/05 22:49:55]

The C++ is probably set up to only take strings. I don't want to mess with that
right now, but yes, any time I see a string literal "null" or "true" or
whatever, I'm suspicious of it...

   requestFlagsExperimentsData();
 }
 
 // Get data and have it displayed upon loading.
 document.addEventListener('DOMContentLoaded', requestFlagsExperimentsData);