JS style nits

chrome/browser/resources/about_stats.js

-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /* Counter accessor for Name Node. */
 function getCounterNameFromCounterNode(node) {
   return node.childNodes[1];
 }
 
 /* Counter accessor for Value Node. */
 function getCounterValueFromCounterNode(node) {
@@ skipping 23 matching lines @@
 /* Timer accessor for Average Time Node. */
 function getTimerAvgTimeFromTimerNode(node) {
   return node.childNodes[7];
 }
 
 /* Do the filter work.  Hide all nodes matching node.*/
 function filterMatching(text, nodelist, functionToGetNameNode) {
   var showAll = text.length == 0;
   for (var i = 0, node; node = nodelist[i]; i++) {
     var name = functionToGetNameNode(node).innerHTML.toLowerCase();
     if (showAll || name.indexOf(text) >= 0) {

[Dan Beam, 2012/04/05 22:24:13]

nit: no curlies

[Tyler Breisacher (Chromium), 2012/04/05 22:39:13]

Done.

-      node.style.display = "table-row";
+      node.style.display = 'table-row';
     } else {
-      node.style.display = "none";
+      node.style.display = 'none';
     }
   }
 }
 
 /* Hides or shows counters based on the user's current filter selection. */
 function doFilter() {
-  var filter = document.getElementById("filter");
+  var filter = document.getElementById('filter');
   var text = filter.value.toLowerCase();
-  var nodes = document.getElementsByName("counter");
+  var nodes = document.getElementsByName('counter');
   filterMatching(text, nodes, getCounterNameFromCounterNode);
-  var nodes = document.getElementsByName("timer");
+  var nodes = document.getElementsByName('timer');
   filterMatching(text, nodes, getTimerNameFromTimerNode);
 }
 
 /* Colors the counters based on increasing or decreasing value. */
 function doColor() {
-  var nodes = document.getElementsByName("counter");
+  var nodes = document.getElementsByName('counter');
   for (var i = 0, node; node = nodes[i]; i++) {
     var child = getCounterDeltaFromCounterNode(node);
     var delta = child.innerHTML;
     if (delta > 0) {

[Dan Beam, 2012/04/05 22:24:13]

nor here

[Tyler Breisacher (Chromium), 2012/04/05 22:39:13]

Done.

-      child.style.color = "Green";
+      child.style.color = 'Green';
     } else if (delta == 0) {
-      child.style.color = "Black";
+      child.style.color = 'Black';
     } else {
-      child.style.color = "Red";
+      child.style.color = 'Red';
     }
   }
 }
 
 /* Counters with no values are null. Remove them. */
 function removeNullValues() {
-  var nodes = document.getElementsByName("counter");
+  var nodes = document.getElementsByName('counter');
   for (var i = nodes.length - 1; i >= 0; i--) {
     var node = nodes[i];
     var value = getCounterValueFromCounterNode(node).innerHTML;
-    if (value == "null") {
+    if (value == 'null') {

[Dan Beam, 2012/04/05 22:24:13]

:^( == 'null', nor here

[Tyler Breisacher (Chromium), 2012/04/05 22:39:13]

Done.

       node.parentNode.removeChild(node);
     }
   }
-  var nodes = document.getElementsByName("timer");
+  var nodes = document.getElementsByName('timer');
   for (var i = 0, node; node = nodes[i]; i++) {
     var value_node = getTimerValueFromTimerNode(node);
-    if (value_node.innerHTML == "null") {
-      value_node.innerHTML = "";
+    if (value_node.innerHTML == 'null') {

[Dan Beam, 2012/04/05 22:24:13]

:_( == 'null', nor here

[Tyler Breisacher (Chromium), 2012/04/05 22:39:13]

Done.

+      value_node.innerHTML = '';
     }
   }
 }
 
 /* Compute the average time for timers */
 function computeTimes() {
-  var nodes = document.getElementsByName("timer");
+  var nodes = document.getElementsByName('timer');
   for (var i = 0, node; node = nodes[i]; i++) {
     var count = getTimerValueFromTimerNode(node).innerHTML;
     if (count.length > 0) {
       var time = getTimerTimeFromTimerNode(node).innerHTML;
       var avg = getTimerAvgTimeFromTimerNode(node);
       avg.innerHTML = Math.round(time / count * 100) / 100;
     }
   }
 }
 
 /* All the work we do onload. */
 function onLoadWork() {
   // This is the javascript code that processes the template:
   var input = new JsEvalContext(templateData);
   var output = document.getElementById('t');
   jstProcess(input, output);
 
   // Add handlers to dynamically created HTML elements.
-  var elements = document.getElementsByName("string-sort");
+  var elements = document.getElementsByName('string-sort');
   for (var i = 0; i < elements.length; ++i)
-    elements[i].onclick = function () { sort_table("string"); };
+    elements[i].onclick = function() { sort_table('string'); };
 
-  elements = document.getElementsByName("number-sort");
+  elements = document.getElementsByName('number-sort');
   for (i = 0; i < elements.length; ++i)
-    elements[i].onclick = function () { sort_table("number"); };
+    elements[i].onclick = function() { sort_table('number'); };
 
   doColor();
   removeNullValues();
   computeTimes();
-  document.getElementById("filter").focus();
+  document.getElementById('filter').focus();
 }
 
 // The function should only be used as the event handler
 // on a table cell element. To use it, put it in a <td> element:
 //  <td onclick="sort('string')" ...>
 //
 // The function sorts rows after the row with onclick event handler.
 //
 // type: the data type, 'string', 'number'
-function sort_table(type){
+function sort_table(type) {
   var cell = event.target;
   var cnum = cell.cellIndex;
 
   var row = cell.parentNode;
   var start_index = row.rowIndex + 1;
 
   var tbody = row.parentNode;
   var table = tbody.parentNode;
 
   var rows = new Array();
 
   var indexes = new Array();
   // skip the first row
   for (var i = start_index; i < table.rows.length; i++)
     rows.push(table.rows[i]);
 
   // a, b are strings
-  function compare_strings(a,b) {
+  function compare_strings(a, b) {
     if (a == b) return 0;
     if (a < b) return -1;
     return 1;
   }
 
   // a, b are numbers
-  function compare_numbers(a,b) {
+  function compare_numbers(a, b) {
     var x = isNaN(a) ? 0 : a;
     var y = isNaN(b) ? 0 : b;
     return x - y;
   }
 
   var sort_func = undefined;

[Dan Beam, 2012/04/05 22:24:13]

remove "= undefined"

[Tyler Breisacher (Chromium), 2012/04/05 22:39:13]

Done.

   if (type === 'string') {
     sort_func = function(a, b) {
       var x = a.cells[cnum].innerText;
       var y = b.cells[cnum].innerText;
       return compare_strings(x, y);
-    } ;
+    };
 
   } else if (type === 'number') {
     sort_func = function(a, b) {
       var x = parseFloat(a.cells[cnum].innerText);
       var y = parseFloat(b.cells[cnum].innerText);
       return compare_numbers(x, y);
     }

[Dan Beam, 2012/04/05 22:24:13]

nit: ;

[Tyler Breisacher (Chromium), 2012/04/05 22:39:13]

Done.

   }
 
   rows.sort(sort_func);
 
   // change tables
   if (cell._reverse) {
     for (var i = rows.length - 1; i >= 0; i--)
       tbody.appendChild(rows[i]);
     cell._reverse = false;
   } else {
     for (var i = 0; i < rows.length; i++)
       tbody.appendChild(rows[i]);
     cell._reverse = true;
   }
 }
 
 document.addEventListener('DOMContentLoaded', onLoadWork);

[Dan Beam, 2012/04/05 22:24:13]

nit: no \n

[Tyler Breisacher (Chromium), 2012/04/05 22:39:13]

Done.