Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 10010004: Implement @runtime-error in co19 tests for static analysis (no runtime) (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Formatting fix. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index b4a503cbdaeb9a3fbb7c2268ce1561e29831babd..fa06f77db9a157e6b77b55d65faaa6d671bbfd41 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -750,6 +750,17 @@ class StandardTestSuite implements TestSuite {
return null;
}
}
+
+ String get hasRuntime() {
+ switch(configuration['runtime']) {
+ case null:
+ Expect.fail("configuration['runtime'] is not set");
+ case 'none':
+ return false;
+ default:
+ return true;
+ }
+ }
String getHtmlName(String filename) {
return filename.replaceAll('/', '_').replaceAll(':', '_')
@@ -896,8 +907,11 @@ class StandardTestSuite implements TestSuite {
otherScripts.addAll(match[1].split(' ').filter((e) => e != ''));
}
- if (contents.contains("@compile-error") ||
- contents.contains("@runtime-error")) {
+ if (contents.contains("@compile-error")) {
+ isNegative = true;
+ }
+
+ if (contents.contains("@runtime-error") && hasRuntime) {
isNegative = true;
}

Powered by Google App Engine
This is Rietveld 408576698