Issue 10009037: Chrome 18 specific fix for fixing HTML5 audio output on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10009037: Chrome 18 specific fix for fixing HTML5 audio output on Mac. (Closed)

Created:
8 years, 8 months ago by scherkus (not reviewing)

Modified:
8 years, 8 months ago

Reviewers:
vrk (LEFT CHROMIUM), karen

CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, jam, acolwell+watch_chromium.org, annacc+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing), ihf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1025/src/

Visibility:
Public.

More Reviews

Description

Chrome 18 specific fix for fixing HTML5 audio output on Mac. BUG=109441 TEST=Adjust Audio MIDI settings on a mac then restart the machine. Build without this change should not play any HTML5 audio. Build including this change should play HTML5 audio. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=131184

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -0 lines)			Patch
	M	content/renderer/media/audio_device.cc	View		1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

vrk: can you take a look? karen: FYI this is for 1025 branch

8 years, 8 months ago (2012-04-06 04:39:46 UTC) #1

lgtm

Expand Messages | Collapse Messages