Issue 10008107: Improve MockXKeyboard.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10008107: Improve MockXKeyboard. (Closed)

Created:
8 years, 8 months ago by Yusuke Sato

Modified:
8 years, 8 months ago

Reviewers:
yoshiki

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Improve MockXKeyboard. This is necessary to use the mock in chrome/browser/ui/views/ash/caps_lock_handler_browsertest.cc. BUG=None TEST=try Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132373

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -7 lines)			Patch
	M	chrome/browser/chromeos/input_method/mock_xkeyboard.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	chrome/browser/chromeos/input_method/mock_xkeyboard.cc	View		3 chunks	+18 lines, -7 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/10008107/1

8 years, 8 months ago (2012-04-16 03:03:57 UTC) #4

commit-bot: I haz the power

8 years, 8 months ago (2012-04-16 05:30:00 UTC) #5

Try job failure for 10008107-1 (retry) on win_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Expand Messages | Collapse Messages